linux-kernel - Re: [PATCH v6 02/10] x86/acpi: Move acpi_wakeup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251110174938.GA26690@ranerica-svr.sc.intel.com>
Date: Mon, 10 Nov 2025 09:49:38 -0800
From: Ricardo Neri <ricardo.neri-calderon@...ux.intel.com>
To: Borislav Petkov <bp@...en8.de>
Cc: x86@...nel.org, Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Rob Herring <robh@...nel.org>,
	"K. Y. Srinivasan" <kys@...rosoft.com>,
	Haiyang Zhang <haiyangz@...rosoft.com>,
	Wei Liu <wei.liu@...nel.org>, Dexuan Cui <decui@...rosoft.com>,
	Michael Kelley <mhklinux@...look.com>,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	Saurabh Sengar <ssengar@...ux.microsoft.com>,
	Chris Oo <cho@...rosoft.com>, "Kirill A. Shutemov" <kas@...nel.org>,
	linux-hyperv@...r.kernel.org, devicetree@...r.kernel.org,
	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
	Ricardo Neri <ricardo.neri@...el.com>,
	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
	Yunhong Jiang <yunhong.jiang@...ux.intel.com>
Subject: Re: [PATCH v6 02/10] x86/acpi: Move acpi_wakeup_cpu() and helpers to
 smpwakeup.c

On Mon, Nov 03, 2025 at 02:40:37PM +0100, Borislav Petkov wrote:
> On Wed, Oct 29, 2025 at 10:43:50PM -0700, Ricardo Neri wrote:
> > I did not want to enable the whole of ACPI code as I need a tiny portion of it.
> > Then yes, saving memory and having a smaller binary were considerations.
> > 
> > The only dependency that ACPI_MADT_WAKEUP has on ACPI is the code to read and
> > parse the ACPI table that enumerates the mailbox. (There are a couple of
> > declarations for CPU offlining that need tweaking if I want ACPI_MADT_WAKEUP to
> > not depend on ACPI at all).
> > 
> > The DeviceTree firmware only needs the code to wake CPUs up. That is the code
> > I am carving out.
> > 
> > Having said that, vmlinux and bzImage increase by 4% if I enable ACPI.
> 
> So, is it a concern or not? I cannot understand from the above whether you
> care about 4% or not.

I apologize for my late reply. Also, I am sorry I was not clear. I needed to
consult with a few stakeholders whether they could live with the increase in
size resulting from having CONFIG_ACPI=y. They can.

If it is OK with Rafael, I plan to post a new version that drops this patch and
adds the necessary function stubs for the !CONFIG_ACPI case.

Thanks and BR,
Ricardo