linux-kernel - Re: [PATCH] net: aquantia: Add missing descriptor cache invalidation on ATL2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aRIlWAR1Px-OFKEr@horms.kernel.org>
Date: Mon, 10 Nov 2025 17:48:08 +0000
From: Simon Horman <horms@...nel.org>
To: Kai-Heng Feng <kaihengf@...dia.com>
Cc: irusskikh@...vell.com, Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: aquantia: Add missing descriptor cache invalidation
 on ATL2

On Fri, Nov 07, 2025 at 01:20:48PM +0800, Kai-Heng Feng wrote:
> ATL2 hardware was missing descriptor cache invalidation in hw_stop(),
> causing SMMU translation faults during device shutdown and module removal.
> 
> Commit 7a1bb49461b1 ("net: aquantia: fix potential IOMMU fault after
> driver unbind") and commit ed4d81c4b3f2 ("net: aquantia: when cleaning
> hw cache it should be toggled") fixed cache invalidation for ATL B0, but
> ATL2 was left with only interrupt disabling. This allowed hardware to
> write to cached descriptors after DMA memory was unmapped, triggering
> SMMU faults.
> 
> Add shared aq_hw_invalidate_descriptor_cache() helper and use it in both
> ATL B0 and ATL2 hw_stop() implementations for consistent behavior.

I think it would be useful to mention how this bug was found.
And what sort of testing has been conducted: compilation only,
exercised on real hardware, ...

As a bug fix I think this should have a Fixes tag denoting
the commit that introduced the problem. In this case, perhaps:

Fixes: e54dcf4bba3e ("net: atlantic: basic A2 init/deinit hw_ops")

The fixes tag should go immediately above your signed-off-by line,
with no blank lines in between.

> Signed-off-by: Kai-Heng Feng <kaihengf@...dia.com>

And lastly, for reference: as a fix for code present in the net tree, this
should be targeted at that tree, which should be denoted in the Subject
like this:

Subject: [PATCH net] ...

You can see more on process for Networking patches here:
https://docs.kernel.org/process/maintainer-netdev.html

...