linux-kernel - Re: [PATCH v4 1/2] iio: trigger: add missing mutex_destroy in iio_trig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aRF3fokq4u0-JYd9@smile.fi.intel.com>
Date: Mon, 10 Nov 2025 07:26:22 +0200
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Ma Ke <make24@...as.ac.cn>
Cc: jic23@...nel.org, dlechner@...libre.com, nuno.sa@...log.com,
	andy@...nel.org, linux-iio@...r.kernel.org,
	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org
Subject: Re: [PATCH v4 1/2] iio: trigger: add missing mutex_destroy in
 iio_trig_release

On Mon, Nov 10, 2025 at 11:57:01AM +0800, Ma Ke wrote:
> Add missing mutex_destroy() call in iio_trig_release() to properly
> clean up the mutex initialized in viio_trigger_alloc(). Ensure proper
> resource cleanup and follows kernel practices.
> 
> Found by code review.

First of all, the patches should form the series and include a cover letter,
usually it can be done by running

	git format-patch -v<X> --cover-letter --base ...

against the branch where changes are located on top of.

Then, here makes sense to add

Suggested-by:: Andy Shevchenko <andriy.shevchenko@...el.com>

The change otherwise LGTM (no need to resend this time),

Reviewed-by:: Andy Shevchenko <andriy.shevchenko@...el.com>


-- 
With Best Regards,
Andy Shevchenko