linux-kernel - Re: [PATCH v18 1/6] dt-bindings: pwm: add IPQ6018 binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tqbdvt2yj2e7ycxiu7nlvwgeh4cf7em6n7gia7cd4f7lsqjdeg@ksyfpy63laop>
Date: Mon, 10 Nov 2025 19:36:21 +0100
From: Uwe Kleine-König <ukleinek@...nel.org>
To: George Moussalem <george.moussalem@...look.com>
Cc: Bjorn Andersson <andersson@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Baruch Siach <baruch@...s.co.il>, Konrad Dybcio <konradybcio@...nel.org>, 
	linux-arm-msm@...r.kernel.org, linux-pwm@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Devi Priya <quic_devipriy@...cinc.com>, 
	Baruch Siach <baruch.siach@...lu.com>, Krzysztof Kozlowski <krzk@...nel.org>
Subject: Re: [PATCH v18 1/6] dt-bindings: pwm: add IPQ6018 binding

Hello George,

On Mon, Nov 10, 2025 at 03:41:49PM +0400, George Moussalem wrote:
> On 11/10/25 15:32, Uwe Kleine-König wrote:
> >>> +  "#pwm-cells":
> >>> +    const: 2
> > 
> > Please use 3 here.
> 
> The driver doesn't support polarity and I don't know whether the HW even
> supports it. Hence, I kept it as 2 as originally submitted by qcom
> (Devi). I don't have access to the datasheets. Would you like me to
> resubmit a new version anyways or keep as is?

I want all new drivers use 3 pwm-cells for consistency even if the
hardware doesn't support the (currently) only flag. Additionally this
simplifies things like pwm nexus nodes (see
e71e46a6f19c46b38983bebde8bfac1c04968fdf).

So yes, please change to 3.

Best regards
Uwe

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)