[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ecc69a98a23d406ea1eada62144415fc@ti.com>
Date: Mon, 10 Nov 2025 05:29:01 +0000
From: "Xu, Baojun" <baojun.xu@...com>
To: Krzysztof Kozlowski <krzk@...nel.org>
CC: "broonie@...nel.org" <broonie@...nel.org>, "tiwai@...e.de"
<tiwai@...e.de>, "andriy.shevchenko@...ux.intel.com"
<andriy.shevchenko@...ux.intel.com>, "13916275206@....com"
<13916275206@....com>, "Ding, Shenghao" <shenghao-ding@...com>,
"linux-sound@...r.kernel.org" <linux-sound@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"lgirdwood@...il.com" <lgirdwood@...il.com>, "robh@...nel.org"
<robh@...nel.org>, "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
"conor+dt@...nel.org" <conor+dt@...nel.org>, "devicetree@...r.kernel.org"
<devicetree@...r.kernel.org>, "Yi, Ken" <k-yi@...com>, "Lo, Henry"
<henry.lo@...com>, "Chen, Robin" <robinchen@...com>, "Wang, Will"
<will-wang@...com>, "jim.shil@...rtek.com" <jim.shil@...rtek.com>,
"toastcheng@...gle.com" <toastcheng@...gle.com>, "chinkaiting@...gle.com"
<chinkaiting@...gle.com>
Subject: Re: [EXTERNAL] Re: [PATCH v1 2/2] ASoC: dt-bindings: ti,tas2781: Add
TAS2568/5806M/5806MD/5830 support
>
> ________________________________________
> From: Krzysztof Kozlowski <krzk@...nel.org>
> Sent: 10 November 2025 01:17
> To: Xu, Baojun
> Cc: broonie@...nel.org; tiwai@...e.de; andriy.shevchenko@...ux.intel.com; 13916275206@....com; Ding, Shenghao; linux-sound@...r.kernel.org; linux-kernel@...r.kernel.org; lgirdwood@...il.com; robh@...nel.org; krzk+dt@...nel.org; conor+dt@...nel.org; devicetree@...r.kernel.org; Yi, Ken; Lo, Henry; Chen, Robin; Ji, Jesse; Wang, Will; jim.shil@...rtek.com; toastcheng@...gle.com; chinkaiting@...gle.com
> Subject: [EXTERNAL] Re: [PATCH v1 2/2] ASoC: dt-bindings: ti,tas2781: Add TAS2568/5806M/5806MD/5830 support
>
> On Sat, Nov 08, 2025 at 07:07:59PM +0800, Baojun Xu wrote:
> > TAS5806M, TAS5806MD and TAS5830 is in same family with TAS58XX.
> > TAS2568 is in family with TAS257X.
> >
> > Signed-off-by: Baojun Xu <baojun.xu@...com>
> > ---
> > .../devicetree/bindings/sound/ti,tas2781.yaml | 25 +++++++++++++++++++
> > 1 file changed, 25 insertions(+)
> >
>
> Please organize the patch documenting compatible (DT bindings) before their user.
> See also: https://urldefense.com/v3/__https://elixir.bootlin.com/linux/v6.14-rc6/source/Documentation/devicetree/bindings/submitting-patches.rst*L46__;Iw!!G3vK!SQ5aH9VZhZ2QzKdtYIs5BX7OarVmt1XzwB9XxqFgAGN0ONvsEoAjHsuoZWrrmetzH_xlxeSfWA$
Hi Krzysztof,
Thanks for your review.
Do you mean I need to add a text file,
for example "ti,tas2781.txt", include the required properties,
and the example of the devicetree node?
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>
> Best regards,
> Krzysztof
>
Best Regards
Jim
Powered by blists - more mailing lists