| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <3c165812702df97243710e1978a816157c697d9e.camel@ibm.com>
Date: Mon, 10 Nov 2025 19:13:27 +0000
From: Viacheslav Dubeyko <Slava.Dubeyko@....com>
To: "casey@...aufler-ca.com" <casey@...aufler-ca.com>,
"linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
"mani@...nel.org" <mani@...nel.org>,
"pmladek@...e.com" <pmladek@...e.com>,
"intel-xe@...ts.freedesktop.org" <intel-xe@...ts.freedesktop.org>,
"linux-staging@...ts.linux.dev" <linux-staging@...ts.linux.dev>,
"dmitry.baryshkov@....qualcomm.com" <dmitry.baryshkov@....qualcomm.com>,
"vitaly.lifshits@...el.com" <vitaly.lifshits@...el.com>,
"amd-gfx@...ts.freedesktop.org" <amd-gfx@...ts.freedesktop.org>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
"ulf.hansson@...aro.org" <ulf.hansson@...aro.org>,
"max.kellermann@...os.com"
<max.kellermann@...os.com>,
"kartilak@...co.com" <kartilak@...co.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"christian.koenig@....com" <christian.koenig@....com>,
"linux-s390@...r.kernel.org" <linux-s390@...r.kernel.org>,
"linaro-mm-sig@...ts.linaro.org" <linaro-mm-sig@...ts.linaro.org>,
"linux-trace-kernel@...r.kernel.org" <linux-trace-kernel@...r.kernel.org>,
"corey@...yard.net" <corey@...yard.net>,
"hverkuil@...nel.org"
<hverkuil@...nel.org>,
"calvin@...nvd.org" <calvin@...nvd.org>,
"ceph-devel@...r.kernel.org" <ceph-devel@...r.kernel.org>,
"openipmi-developer@...ts.sourceforge.net"
<openipmi-developer@...ts.sourceforge.net>,
"linux@...blig.org"
<linux@...blig.org>,
"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
"rostedt@...dmis.org" <rostedt@...dmis.org>,
"matthew.brost@...el.com"
<matthew.brost@...el.com>,
"linux-scsi@...r.kernel.org"
<linux-scsi@...r.kernel.org>,
"andriy.shevchenko@...ux.intel.com"
<andriy.shevchenko@...ux.intel.com>,
"martin.petersen@...cle.com"
<martin.petersen@...cle.com>,
"freedreno@...ts.freedesktop.org"
<freedreno@...ts.freedesktop.org>,
"alexander.deucher@....com"
<alexander.deucher@....com>,
"maimon.sagi@...il.com" <maimon.sagi@...il.com>,
"linux-sound@...r.kernel.org" <linux-sound@...r.kernel.org>,
"tiwai@...e.de"
<tiwai@...e.de>,
"cassel@...nel.org" <cassel@...nel.org>,
"robin.clark@....qualcomm.com" <robin.clark@....qualcomm.com>,
"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
"laurent.pinchart+renesas@...asonboard.com"
<laurent.pinchart+renesas@...asonboard.com>,
"linux-arm-msm@...r.kernel.org"
<linux-arm-msm@...r.kernel.org>,
"linux-doc@...r.kernel.org"
<linux-doc@...r.kernel.org>,
"tzimmermann@...e.de" <tzimmermann@...e.de>
CC: "borntraeger@...ux.ibm.com" <borntraeger@...ux.ibm.com>,
"senozhatsky@...omium.org" <senozhatsky@...omium.org>,
"jonathan.lemon@...il.com" <jonathan.lemon@...il.com>,
"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
"lumag@...nel.org"
<lumag@...nel.org>,
"andrew@...n.ch" <andrew@...n.ch>,
"olteanv@...il.com"
<olteanv@...il.com>,
"davem@...emloft.net" <davem@...emloft.net>,
"przemyslaw.kitszel@...el.com" <przemyslaw.kitszel@...el.com>,
"marijn.suijten@...ainline.org" <marijn.suijten@...ainline.org>,
"linux@...musvillemoes.dk" <linux@...musvillemoes.dk>,
"mripard@...nel.org"
<mripard@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
"hca@...ux.ibm.com"
<hca@...ux.ibm.com>,
"hoeppner@...ux.ibm.com" <hoeppner@...ux.ibm.com>,
"corbet@....net" <corbet@....net>,
"anthony.l.nguyen@...el.com"
<anthony.l.nguyen@...el.com>,
"mathieu.desnoyers@...icios.com"
<mathieu.desnoyers@...icios.com>,
"satishkh@...co.com" <satishkh@...co.com>,
"sumit.semwal@...aro.org" <sumit.semwal@...aro.org>,
"giometti@...eenne.com"
<giometti@...eenne.com>,
"gustavo@...ovan.org" <gustavo@...ovan.org>,
"kuba@...nel.org" <kuba@...nel.org>,
"vadim.fedorenko@...ux.dev"
<vadim.fedorenko@...ux.dev>,
"thomas.hellstrom@...ux.intel.com"
<thomas.hellstrom@...ux.intel.com>,
"lucas.demarchi@...el.com"
<lucas.demarchi@...el.com>,
"rodrigo.vivi@...el.com"
<rodrigo.vivi@...el.com>,
"mhiramat@...nel.org" <mhiramat@...nel.org>,
"jesszhan0024@...il.com" <jesszhan0024@...il.com>,
"sean@...rly.run"
<sean@...rly.run>,
"mchehab@...nel.org" <mchehab@...nel.org>,
"bhelgaas@...gle.com" <bhelgaas@...gle.com>,
"simona@...ll.ch"
<simona@...ll.ch>,
"airlied@...il.com" <airlied@...il.com>,
"kishon@...nel.org" <kishon@...nel.org>,
"konradybcio@...nel.org"
<konradybcio@...nel.org>,
"tiwai@...e.com" <tiwai@...e.com>,
"agordeev@...ux.ibm.com" <agordeev@...ux.ibm.com>,
"gor@...ux.ibm.com"
<gor@...ux.ibm.com>,
"edumazet@...gle.com" <edumazet@...gle.com>,
"kwilczynski@...nel.org" <kwilczynski@...nel.org>,
"sebaddel@...co.com"
<sebaddel@...co.com>,
"gregkh@...uxfoundation.org"
<gregkh@...uxfoundation.org>,
"idryomov@...il.com" <idryomov@...il.com>,
"maarten.lankhorst@...ux.intel.com" <maarten.lankhorst@...ux.intel.com>,
"abhinav.kumar@...ux.dev" <abhinav.kumar@...ux.dev>,
"richardcochran@...il.com" <richardcochran@...il.com>,
"sth@...ux.ibm.com"
<sth@...ux.ibm.com>,
"svens@...ux.ibm.com" <svens@...ux.ibm.com>,
"James.Bottomley@...senPartnership.com"
<James.Bottomley@...senPartnership.com>,
Xiubo Li <xiubli@...hat.com>, "perex@...ex.cz" <perex@...ex.cz>
Subject: Re: [PATCH v1 04/23] libceph: Switch to use %ptSp
On Mon, 2025-11-10 at 19:40 +0100, Andy Shevchenko wrote:
> Use %ptSp instead of open coded variants to print content of
> struct timespec64 in human readable format.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
> net/ceph/messenger_v2.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/net/ceph/messenger_v2.c b/net/ceph/messenger_v2.c
> index 9e39378eda00..6e676e2d4ba0 100644
> --- a/net/ceph/messenger_v2.c
> +++ b/net/ceph/messenger_v2.c
> @@ -1535,8 +1535,7 @@ static int prepare_keepalive2(struct ceph_connection *con)
> struct timespec64 now;
>
> ktime_get_real_ts64(&now);
> - dout("%s con %p timestamp %lld.%09ld\n", __func__, con, now.tv_sec,
> - now.tv_nsec);
> + dout("%s con %p timestamp %ptSp\n", __func__, con, &now);
>
> ceph_encode_timespec64(ts, &now);
>
> @@ -2729,8 +2728,7 @@ static int process_keepalive2_ack(struct ceph_connection *con,
> ceph_decode_need(&p, end, sizeof(struct ceph_timespec), bad);
> ceph_decode_timespec64(&con->last_keepalive_ack, p);
>
> - dout("%s con %p timestamp %lld.%09ld\n", __func__, con,
> - con->last_keepalive_ack.tv_sec, con->last_keepalive_ack.tv_nsec);
> + dout("%s con %p timestamp %ptSp\n", __func__, con, &con->last_keepalive_ack);
>
> return 0;
>
Looks good. Nice cleanup.
Reviewed-by: Viacheslav Dubeyko <Slava.Dubeyko@....com>
Thanks,
Slava.
Powered by blists - more mailing lists