linux-kernel - Re: [PATCH v4 2/2] arm64: dts: add support for NXP i.MX8MP FRDM board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9d48a54c-0585-4524-b9d5-30696f5ecc8b@kernel.org>
Date: Mon, 10 Nov 2025 21:12:51 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Rogerio Pimentel <rpimentel.silva@...il.com>, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, shawnguo@...nel.org,
 s.hauer@...gutronix.de
Cc: kernel@...gutronix.de, festevam@...il.com,
 alexander.stein@...tq-group.com, dario.binacchi@...rulasolutions.com,
 marex@...x.de, Markus.Niebel@...group.com, y.moog@...tec.de,
 joao.goncalves@...adex.com, frieder.schrempf@...tron.de,
 josua@...id-run.com, francesco.dolcini@...adex.com, primoz.fiser@...ik.com,
 imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 Xiaofeng Wei <xiaofeng.wei@....com>
Subject: Re: [PATCH v4 2/2] arm64: dts: add support for NXP i.MX8MP FRDM board

On 09/11/2025 22:45, Rogerio Pimentel wrote:
> The FRDM-i.MX8MP is an NXP development platform based on the i.MX8M Plus
> SoC, featuring a quad Cortex-A53, Cortex-M7 co-processor, 4GB LPDDR4,
> 32GB eMMC, Wi-Fi 6/Bluetooth 5.4/802.15.4 tri-radio, Ethernet, HDMI/MIPI
> display interfaces, camera connectors, and standard expansion headers.
> 
> Based on the device tree found in the NXP repository at github
> https://github.com/nxp-imx-support/meta-imx-frdm and on imx8mp-evk
> board kernel mainline device tree.
> 
> This is a basic device tree supporting:
> 
>  - Quad Cortex-A53
>  - 4GB LPDDR4 DRAM
>  - PCA9450C PMIC with regulators
>  - Two NXP PCAL6416 GPIO expanders
>  - RGB LEDs via GPIO expander
>  - I2C1, I2C2, I2C3 controllers
>  - UART2 (console) and UART3 (with RTS/CTS)
>  - USDHC3 (8-bit eMMC)
>  - SNVS power key (onboard power button)
> 
> Signed-off-by: Rogerio Pimentel <rpimentel.silva@...il.com>
> Signed-off-by: Xiaofeng Wei <xiaofeng.wei@....com>

Incorrect DCO chain. Please look at submitting patches which explain
what is DCO and how it should be organized.

> ---
> 
> Changes in v4:




> +
> +	pinctrl_pmic: pmicgrp {
> +		fsl,pins = <
> +			MX8MP_IOMUXC_GPIO1_IO03__GPIO1_IO03	0x000001c0
> +		>;
> +	};
> +
> +	pinctrl_pcal6416_0_int: pcal6416_0_int_grp {


Don't use underscores in node names. See DTS coding style.

Best regards,
Krzysztof