linux-kernel - [PATCH 2/2] checks: Allow "chosen" node under "__overlay_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251110204529.2838248-2-dianders@chromium.org>
Date: Mon, 10 Nov 2025 12:45:27 -0800
From: Douglas Anderson <dianders@...omium.org>
To: Rob Herring <robh@...nel.org>,
	Saravana Kannan <saravanak@...gle.com>
Cc: devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Douglas Anderson <dianders@...omium.org>
Subject: [PATCH 2/2] checks: Allow "chosen" node under "__overlay__" for a DT fragment

If a `dtso` file adds to the chosen node, a false warning will be reported:
  Warning (chosen_node_is_root): /fragment@<num>/__overlay__/chosen: chosen node must be at root node

Allow the "chosen" node to be under the "__overlay__" node at the root
of a fragment.

Signed-off-by: Douglas Anderson <dianders@...omium.org>
---

 checks.c | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/checks.c b/checks.c
index 908df5b98ec5..d28e59494757 100644
--- a/checks.c
+++ b/checks.c
@@ -1371,8 +1371,17 @@ static void check_chosen_node_is_root(struct check *c, struct dt_info *dti,
 	if (!streq(node->name, "chosen"))
 		return;
 
-	if (node->parent != dti->dt)
-		FAIL(c, dti, node, "chosen node must be at root node");
+	if (dti->dtsflags & DTSF_PLUGIN) {
+		const char *frag_path = get_fragment_relative_path(node->fullpath);
+
+		if (frag_path && streq(frag_path, "/__overlay__/chosen"))
+			return;
+	} else {
+		if (node->parent == dti->dt)
+			return;
+	}
+
+	FAIL(c, dti, node, "chosen node must be at root node");
 }
 WARNING(chosen_node_is_root, check_chosen_node_is_root, NULL);
 
-- 
2.51.2.1041.gc1ab5b90ca-goog