linux-kernel - Re: [PATCH] mips: Use generic endianness macros instead of MIPS-specific ones

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251110210835.GA302594@ax162>
Date: Mon, 10 Nov 2025 14:08:35 -0700
From: Nathan Chancellor <nathan@...nel.org>
To: "Maciej W. Rozycki" <macro@...am.me.uk>
Cc: Jens Reidel <adrian@...nlining.org>,
	Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
	Nick Desaulniers <nick.desaulniers+lkml@...il.com>,
	Bill Wendling <morbo@...gle.com>,
	Justin Stitt <justinstitt@...gle.com>, linux-mips@...r.kernel.org,
	linux-kernel@...r.kernel.org, bpf@...r.kernel.org,
	llvm@...ts.linux.dev
Subject: Re: [PATCH] mips: Use generic endianness macros instead of
 MIPS-specific ones

On Mon, Nov 10, 2025 at 01:34:19AM +0000, Maciej W. Rozycki wrote:
>  Also please don't review changes based on assumptions, "I assume GCC 
> does[...]" means that you just don't know (and it's trivial to check).

Yes, that is totally valid. I hastily reviewed this when I should have
taken the time to check but I did not have a MIPS cross compiler
available locally to test and I forgot that I can use Godbolt for that
test. I'll be more mindful of that in the future (or at least being
clear that I did not actually check but it should be verified before the
change is merged without providing a tag).

> target macros.  Since our current GCC requirement is 5.1 it will be fine 

Just an FYI, the minimum GCC version is 8.1 since commit 118c40b7b503
("kbuild: require gcc-8 and binutils-2.30") in 6.16.

Cheers,
Nathan