linux-kernel - drivers/hwtracing/coresight/coresight-tmc-core.c:403:5-8: Unneeded variable: "ret". Return "0" on line 416

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202511110556.RDLHL0DU-lkp@intel.com>
Date: Tue, 11 Nov 2025 05:46:44 +0800
From: kernel test robot <lkp@...el.com>
To: Linu Cherian <lcherian@...vell.com>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
	Suzuki K Poulose <suzuki.poulose@....com>,
	Anil Kumar Reddy <areddy3@...vell.com>,
	Tanmay Jagdale <tanmay@...vell.com>
Subject: drivers/hwtracing/coresight/coresight-tmc-core.c:403:5-8: Unneeded
 variable: "ret". Return "0" on line 416

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   4ea7c1717f3f2344f7a1cdab4f5875cfa89c87a9
commit: d58a70bdab575264fe75e4826464aaef0dd096b4 coresight: tmc: Add support for reading crash data
date:   9 months ago
config: arm64-randconfig-r052-20251110 (https://download.01.org/0day-ci/archive/20251111/202511110556.RDLHL0DU-lkp@intel.com/config)
compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project 0d786b9a207aa0e6d88dde7fd9ffe0b364db69a4)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202511110556.RDLHL0DU-lkp@intel.com/

cocci warnings: (new ones prefixed by >>)
>> drivers/hwtracing/coresight/coresight-tmc-core.c:403:5-8: Unneeded variable: "ret". Return "0" on line 416

vim +403 drivers/hwtracing/coresight/coresight-tmc-core.c

   400	
   401	static int tmc_crashdata_release(struct inode *inode, struct file *file)
   402	{
 > 403		int ret = 0;
   404		unsigned long flags;
   405		struct tmc_resrv_buf *rbuf;
   406		struct tmc_drvdata *drvdata = container_of(file->private_data,
   407							   struct tmc_drvdata,
   408							   crashdev);
   409	
   410		rbuf = &drvdata->resrv_buf;
   411		spin_lock_irqsave(&drvdata->spinlock, flags);
   412		rbuf->reading = false;
   413		spin_unlock_irqrestore(&drvdata->spinlock, flags);
   414	
   415		dev_dbg(&drvdata->csdev->dev, "%s: released\n", __func__);
 > 416		return ret;
   417	}
   418	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki