| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <5961d473-d797-44b3-9182-06d8229387da@lucifer.local>
Date: Mon, 10 Nov 2025 22:03:55 +0000
From: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
To: SeongJae Park <sj@...nel.org>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
Janosch Frank <frankja@...ux.ibm.com>,
Claudio Imbrenda <imbrenda@...ux.ibm.com>,
David Hildenbrand <david@...hat.com>,
Alexander Gordeev <agordeev@...ux.ibm.com>,
Gerald Schaefer <gerald.schaefer@...ux.ibm.com>,
Heiko Carstens <hca@...ux.ibm.com>, Vasily Gorbik <gor@...ux.ibm.com>,
Sven Schnelle <svens@...ux.ibm.com>, Peter Xu <peterx@...hat.com>,
Alexander Viro <viro@...iv.linux.org.uk>,
Christian Brauner <brauner@...nel.org>, Jan Kara <jack@...e.cz>,
Arnd Bergmann <arnd@...db.de>, Zi Yan <ziy@...dia.com>,
Baolin Wang <baolin.wang@...ux.alibaba.com>,
"Liam R . Howlett" <Liam.Howlett@...cle.com>,
Nico Pache <npache@...hat.com>, Ryan Roberts <ryan.roberts@....com>,
Dev Jain <dev.jain@....com>, Barry Song <baohua@...nel.org>,
Lance Yang <lance.yang@...ux.dev>, Muchun Song <muchun.song@...ux.dev>,
Oscar Salvador <osalvador@...e.de>, Vlastimil Babka <vbabka@...e.cz>,
Mike Rapoport <rppt@...nel.org>,
Suren Baghdasaryan <surenb@...gle.com>, Michal Hocko <mhocko@...e.com>,
Matthew Brost <matthew.brost@...el.com>,
Joshua Hahn <joshua.hahnjy@...il.com>, Rakie Kim <rakie.kim@...com>,
Byungchul Park <byungchul@...com>, Gregory Price <gourry@...rry.net>,
Ying Huang <ying.huang@...ux.alibaba.com>,
Alistair Popple <apopple@...dia.com>,
Axel Rasmussen <axelrasmussen@...gle.com>,
Yuanchu Xie <yuanchu@...gle.com>, Wei Xu <weixugc@...gle.com>,
Kemeng Shi <shikemeng@...weicloud.com>,
Kairui Song <kasong@...cent.com>, Nhat Pham <nphamcs@...il.com>,
Baoquan He <bhe@...hat.com>, Chris Li <chrisl@...nel.org>,
Matthew Wilcox <willy@...radead.org>, Jason Gunthorpe <jgg@...pe.ca>,
Leon Romanovsky <leon@...nel.org>, Xu Xin <xu.xin16@....com.cn>,
Chengming Zhou <chengming.zhou@...ux.dev>,
Jann Horn <jannh@...gle.com>, Miaohe Lin <linmiaohe@...wei.com>,
Naoya Horiguchi <nao.horiguchi@...il.com>,
Pedro Falcato <pfalcato@...e.de>,
Pasha Tatashin <pasha.tatashin@...een.com>,
Rik van Riel <riel@...riel.com>, Harry Yoo <harry.yoo@...cle.com>,
Hugh Dickins <hughd@...gle.com>, linux-kernel@...r.kernel.org,
kvm@...r.kernel.org, linux-s390@...r.kernel.org,
linux-fsdevel@...r.kernel.org, linux-mm@...ck.org,
linux-arch@...r.kernel.org, damon@...ts.linux.dev
Subject: Re: [PATCH v2 10/16] mm: replace pmd_to_swp_entry() with
softleaf_from_pmd()
On Sat, Nov 08, 2025 at 09:18:08AM -0800, SeongJae Park wrote:
> On Sat, 8 Nov 2025 17:08:24 +0000 Lorenzo Stoakes <lorenzo.stoakes@...cle.com> wrote:
>
> > Introduce softleaf_from_pmd() to do the equivalent operation for PMDs that
> > softleaf_from_pte() fulfils, and cascade changes through code base
> > accordingly, introducing helpers as necessary.
> >
> > We are then able to eliminate pmd_to_swp_entry(), is_pmd_migration_entry(),
> > is_pmd_device_private_entry() and is_pmd_non_present_folio_entry().
> >
> > This further establishes the use of leaf operations throughout the code
> > base and further establishes the foundations for eliminating is_swap_pmd().
> >
> > No functional change intended.
> >
> > Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
> > ---
> > fs/proc/task_mmu.c | 27 +++--
> > include/linux/leafops.h | 220 ++++++++++++++++++++++++++++++++++++++++
> > include/linux/migrate.h | 2 +-
> > include/linux/swapops.h | 100 ------------------
> > mm/damon/ops-common.c | 6 +-
> > mm/filemap.c | 6 +-
> > mm/hmm.c | 16 +--
> > mm/huge_memory.c | 98 +++++++++---------
> > mm/khugepaged.c | 4 +-
> > mm/madvise.c | 2 +-
> > mm/memory.c | 4 +-
> > mm/mempolicy.c | 4 +-
> > mm/migrate.c | 20 ++--
> > mm/migrate_device.c | 14 +--
> > mm/page_table_check.c | 16 +--
> > mm/page_vma_mapped.c | 15 +--
> > mm/pagewalk.c | 8 +-
> > mm/rmap.c | 4 +-
> > 18 files changed, 343 insertions(+), 223 deletions(-)
> [...]
>
> > diff --git a/mm/damon/ops-common.c b/mm/damon/ops-common.c
> > index 971df8a16ba4..a218d9922234 100644
> > --- a/mm/damon/ops-common.c
> > +++ b/mm/damon/ops-common.c
> > @@ -11,7 +11,7 @@
> > #include <linux/pagemap.h>
> > #include <linux/rmap.h>
> > #include <linux/swap.h>
> > -#include <linux/swapops.h>
> > +#include <linux/leafops.h>
> >
> > #include "../internal.h"
> > #include "ops-common.h"
> > @@ -51,7 +51,7 @@ void damon_ptep_mkold(pte_t *pte, struct vm_area_struct *vma, unsigned long addr
> > if (likely(pte_present(pteval)))
> > pfn = pte_pfn(pteval);
> > else
> > - pfn = swp_offset_pfn(pte_to_swp_entry(pteval));
> > + pfn = softleaf_to_pfn(softleaf_from_pte(pteval));
> >
> > folio = damon_get_folio(pfn);
> > if (!folio)
> > @@ -83,7 +83,7 @@ void damon_pmdp_mkold(pmd_t *pmd, struct vm_area_struct *vma, unsigned long addr
> > if (likely(pmd_present(pmdval)))
> > pfn = pmd_pfn(pmdval);
> > else
> > - pfn = swp_offset_pfn(pmd_to_swp_entry(pmdval));
> > + pfn = softleaf_to_pfn(softleaf_from_pmd(pmdval));
> >
> > folio = damon_get_folio(pfn);
> > if (!folio)
>
> I'll try to take a time to review the whole series. But, for now, for this
> DAMON part change,
>
> Reviewed-by: SeongJae Park <sj@...nel.org>
Thanks :)
>
>
> Thanks,
> SJ
>
> [...]
Cheers, Lorenzo
Powered by blists - more mailing lists