linux-kernel - Re: [PATCH] mwl8k: inject DS Params IE into beacons if missing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f1d7cd013d102972976d39e7fadef9e91a1c6056.camel@sipsolutions.net>
Date: Mon, 10 Nov 2025 08:30:14 +0100
From: Johannes Berg <johannes@...solutions.net>
To: Pawel Dembicki <paweldembicki@...il.com>, linux-wireless@...r.kernel.org
Cc: Antony Kolitsos <zeusomighty@...mail.com>, Roopni Devanathan
	 <quic_rdevanat@...cinc.com>, Thomas Fourier <fourier.thomas@...il.com>, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mwl8k: inject DS Params IE into beacons if missing

Missing wifi: prefix.

> +
> +	/* Inject a DS Params IE at the beginning of the IE list */

It hasn't really been called "IE" ("information element") in years, just
"element". Might want to update your terminology (at least for new
code), same also in subect. Also the element you're talking about is
(now?) "DSSS Parameter Set" in the spec.

> +	buf_dst[hdr_len + 0] = WLAN_EID_DS_PARAMS;
> +	buf_dst[hdr_len + 1] = 1;
> +	buf_dst[hdr_len + 2] = hw->conf.chandef.chan->hw_value;

That's wrong, it should be after the SSID and Supported Rates and BSS
Membership Selectors elements.

Normally this doesn't matter much, but I wouldn't be surprised if there
were implementations that assume the SSID is at a fixed first position.

johannes