linux-kernel - RE: [PATCH v4] ACPI: AGDI: Add interrupt signaling mode support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <OSAPR01MB7669F9B9E145A50B38819E13D5CEA@OSAPR01MB7669.jpnprd01.prod.outlook.com>
Date: Mon, 10 Nov 2025 07:38:17 +0000
From: "Kazuhiro Abe (Fujitsu)" <fj1078ii@...itsu.com>
To: 'Will Deacon' <will@...nel.org>, Hanjun Guo <guohanjun@...wei.com>
CC: Lorenzo Pieralisi <lpieralisi@...nel.org>, Sudeep Holla
	<sudeep.holla@....com>, "Rafael J. Wysocki" <rafael@...nel.org>, Len Brown
	<lenb@...nel.org>, "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, Ilkka Koskinen
	<ilkka@...amperecomputing.com>, Catalin Marinas <catalin.marinas@....com>,
	"Koichi Okuno (Fujitsu)" <fj2767dz@...itsu.com>
Subject: RE: [PATCH v4] ACPI: AGDI: Add interrupt signaling mode support

Hi Will,

> Hi Will,
> 
> > [You don't often get email from will@...nel.org. Learn why this is
> > important at https://aka.ms/LearnAboutSenderIdentification ]
> >
> > On Mon, Oct 20, 2025 at 09:23:05PM +0800, Hanjun Guo wrote:
> > > On 2025/10/17 15:39, Kazuhiro Abe wrote:
> > > > AGDI has two types of signaling modes: SDEI and interrupt.
> > > > Currently, the AGDI driver only supports SDEI.
> > > > Therefore, add support for interrupt signaling mode The interrupt
> > > > vector is retrieved from the AGDI table, and call panic function
> > > > when an interrupt occurs.
> > > >
> > > > Reviewed-by: Ilkka Koskinen <ilkka@...amperecomputing.com>
> > > > Signed-off-by: Kazuhiro Abe <fj1078ii@...jp.fujitsu.com>
> > > > ---
> > > > Hanjun, I have addressed all your comments.
> > > > Please review them.
> > > >
> > > > v3->v4
> > > >   - Add a comment to the flags member.
> > > >   - Fix agdi_interrupt_probe.
> > > >   - Fix agdi_interrupt_remove.
> > > >   - Add space in struct initializsation.
> > > >   - Delete curly braces.
> > >
> > > Looks good to me,
> > >
> > > Acked-by: Hanjun Guo <guohanjun@...wei.com>
> >
> > I wasn't cc'd on the original patch but I couldn't figure out why it
> > uses IRQF_NO_AUTOEN when requesting the irq given that the first thing
> > it does is enable it.
> 
> I misunderstood the usage of request_irq and enable_irq.
> Since there's no need to separate them, I will remove IRQF_NO_AUTOEN and the
> enable_irq call, and send v5.

I found out when calling request_nmi, removing IRQF_NO_AUTOEN results in an error (-EINVAL).
Therefore, I would like to keep IRQF_NO_AUTOEN specified.
If you have any comments on this version, please let me know.

Best Regards,
Kazuhiro Abe

> 
> Best Regards,
> Kazuhiro Abe
> 
> >
> > Will