linux-kernel - Re: [PATCH 3/4] riscv: dts: spacemit: add Gigabit Ethernet and PDMA to OrangePi R2S

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251110-brilliant-spiritual-hound-048ced@kuoka>
Date: Mon, 10 Nov 2025 09:04:18 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: michael.opdenacker@...tcommit.com
Cc: Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Yixun Lan <dlan@...too.org>, 
	Paul Walmsley <pjw@...nel.org>, Palmer Dabbelt <palmer@...belt.com>, 
	Albert Ou <aou@...s.berkeley.edu>, Alexandre Ghiti <alex@...ti.fr>, devicetree@...r.kernel.org, 
	linux-riscv@...ts.infradead.org, spacemit@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] riscv: dts: spacemit: add Gigabit Ethernet and PDMA
 to OrangePi R2S

On Sun, Nov 09, 2025 at 10:30:09PM +0000, michael.opdenacker@...tcommit.com wrote:
> From: Michael Opdenacker <michael.opdenacker@...tcommit.com>
> 
> The OrangePi R2S board includes two RGMII ethernet ports
> supporting Gigabit Ethernet operation.
> 
> They have an external Motorcomm YT8531C PHY attached,
> the PHY uses GPIO for reset pin control. Their description
> was reused from the DTS from the OrangePi RV2 board.
> 
> Enable PDMA for the SpacemiT K1-based SoC.
> 
> Signed-off-by: Michael Opdenacker <michael.opdenacker@...tcommit.com>
> 
> ---
> 

Squash the patch. You just added this board. Adding board is one commit.
Why adding incomplete or even buggy code just to fix it immediately?

Best regards,
Krzysztof

Best regards,
Krzysztof