linux-kernel - Re: [PATCH] usb: typec: tipd: mark as orientation aware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aRGggpULQM3xH-pS@kuha.fi.intel.com>
Date: Mon, 10 Nov 2025 10:21:22 +0200
From: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To: Peter Korsgaard <peter@...sgaard.com>
Cc: javier.carrasco@...fvision.net, neal@...pa.dev,
	gregkh@...uxfoundation.org, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: typec: tipd: mark as orientation aware

Fri, Nov 07, 2025 at 04:13:10PM +0100, Peter Korsgaard kirjoitti:
> The driver contains orientation detection logic and correctly calls
> typec_set_orientation(), but forgets to set the orientation_aware
> capability, so the orientation value is not visible in sysfs - Fix that.
> 
> Signed-off-by: Peter Korsgaard <peter@...sgaard.com>

Reviewed-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>

> ---
>  drivers/usb/typec/tipd/core.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c
> index 2b1049c9a6f3..d561032a2970 100644
> --- a/drivers/usb/typec/tipd/core.c
> +++ b/drivers/usb/typec/tipd/core.c
> @@ -1695,6 +1695,7 @@ tps25750_register_port(struct tps6598x *tps, struct fwnode_handle *fwnode)
>  	typec_cap.data = ret;
>  	typec_cap.revision = USB_TYPEC_REV_1_3;
>  	typec_cap.pd_revision = 0x300;
> +	typec_cap.orientation_aware = true;
>  	typec_cap.driver_data = tps;
>  	typec_cap.ops = &tps6598x_ops;
>  	typec_cap.fwnode = fwnode;
> -- 
> 2.39.5

-- 
heikki