linux-kernel - Re: [PATCH 09/13] sched_ext: Make handle_lockup() propagate scx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aRGigc4YQFsyK7Hd@gpd4>
Date: Mon, 10 Nov 2025 09:29:53 +0100
From: Andrea Righi <andrea.righi@...ux.dev>
To: Tejun Heo <tj@...nel.org>
Cc: David Vernet <void@...ifault.com>, Changwoo Min <changwoo@...lia.com>,
	Dan Schatzberg <schatzberg.dan@...il.com>,
	Emil Tsalapatis <etsal@...a.com>, sched-ext@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 09/13] sched_ext: Make handle_lockup() propagate
 scx_verror() result

On Sun, Nov 09, 2025 at 08:31:08AM -1000, Tejun Heo wrote:
> handle_lockup() currently calls scx_verror() but ignores its return value,
> always returning true when the scheduler is enabled. Make it capture and return
> the result from scx_verror(). This prepares for hardlockup handling.
> 
> Cc: Dan Schatzberg <schatzberg.dan@...il.com>
> Cc: Emil Tsalapatis <etsal@...a.com>
> Signed-off-by: Tejun Heo <tj@...nel.org>

Reviewed-by: Andrea Righi <arighi@...dia.com>

Thanks,
-Andrea

> ---
>  kernel/sched/ext.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/sched/ext.c b/kernel/sched/ext.c
> index 5c75b0125dfe..4507bc4f0b5c 100644
> --- a/kernel/sched/ext.c
> +++ b/kernel/sched/ext.c
> @@ -3658,6 +3658,7 @@ static __printf(1, 2) bool handle_lockup(const char *fmt, ...)
>  {
>  	struct scx_sched *sch;
>  	va_list args;
> +	bool ret;
>  
>  	guard(rcu)();
>  
> @@ -3669,9 +3670,9 @@ static __printf(1, 2) bool handle_lockup(const char *fmt, ...)
>  	case SCX_ENABLING:
>  	case SCX_ENABLED:
>  		va_start(args, fmt);
> -		scx_verror(sch, fmt, args);
> +		ret = scx_verror(sch, fmt, args);
>  		va_end(args);
> -		return true;
> +		return ret;
>  	default:
>  		return false;
>  	}
> -- 
> 2.51.1
>