linux-kernel - Re: [PATCH] mm: vmstat: correct the comment above preempt_disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cff1f137-06dd-4045-942a-b5e56a63f47d@suse.cz>
Date: Mon, 10 Nov 2025 09:53:37 +0100
From: Vlastimil Babka <vbabka@...e.cz>
To: Qi Zheng <qi.zheng@...ux.dev>, akpm@...ux-foundation.org,
 david@...nel.org, lorenzo.stoakes@...cle.com, Liam.Howlett@...cle.com,
 rppt@...nel.org, surenb@...gle.com, mhocko@...e.com, harry.yoo@...cle.com
Cc: linux-mm@...ck.org, linux-kernel@...r.kernel.org,
 Qi Zheng <zhengqi.arch@...edance.com>
Subject: Re: [PATCH] mm: vmstat: correct the comment above
 preempt_disable_nested()

On 11/10/25 09:44, Qi Zheng wrote:
> From: Qi Zheng <zhengqi.arch@...edance.com>
> 
> The comment explaining why these parts use preempt_disable_nested() is in
> __mod_zone_page_state(), not in __mod_node_page_state(), so we should see
> __mod_zone_page_state(). Just correct it.
> 
> Signed-off-by: Qi Zheng <zhengqi.arch@...edance.com>

Acked-by: Vlastimil Babka <vbabka@...e.cz>

> ---
>  mm/vmstat.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/mm/vmstat.c b/mm/vmstat.c
> index b53b07aa29e81..65de88cdf40e6 100644
> --- a/mm/vmstat.c
> +++ b/mm/vmstat.c
> @@ -392,7 +392,7 @@ void __mod_node_page_state(struct pglist_data *pgdat, enum node_stat_item item,
>  		delta >>= PAGE_SHIFT;
>  	}
>  
> -	/* See __mod_node_page_state */
> +	/* See __mod_zone_page_state() */
>  	preempt_disable_nested();
>  
>  	x = delta + __this_cpu_read(*p);
> @@ -438,7 +438,7 @@ void __inc_zone_state(struct zone *zone, enum zone_stat_item item)
>  	s8 __percpu *p = pcp->vm_stat_diff + item;
>  	s8 v, t;
>  
> -	/* See __mod_node_page_state */
> +	/* See __mod_zone_page_state() */
>  	preempt_disable_nested();
>  
>  	v = __this_cpu_inc_return(*p);
> @@ -461,7 +461,7 @@ void __inc_node_state(struct pglist_data *pgdat, enum node_stat_item item)
>  
>  	VM_WARN_ON_ONCE(vmstat_item_in_bytes(item));
>  
> -	/* See __mod_node_page_state */
> +	/* See __mod_zone_page_state() */
>  	preempt_disable_nested();
>  
>  	v = __this_cpu_inc_return(*p);
> @@ -494,7 +494,7 @@ void __dec_zone_state(struct zone *zone, enum zone_stat_item item)
>  	s8 __percpu *p = pcp->vm_stat_diff + item;
>  	s8 v, t;
>  
> -	/* See __mod_node_page_state */
> +	/* See __mod_zone_page_state() */
>  	preempt_disable_nested();
>  
>  	v = __this_cpu_dec_return(*p);
> @@ -517,7 +517,7 @@ void __dec_node_state(struct pglist_data *pgdat, enum node_stat_item item)
>  
>  	VM_WARN_ON_ONCE(vmstat_item_in_bytes(item));
>  
> -	/* See __mod_node_page_state */
> +	/* See __mod_zone_page_state() */
>  	preempt_disable_nested();
>  
>  	v = __this_cpu_dec_return(*p);