linux-kernel - Re: [PATCH] ARM: dts: stm32: lxa: drop unnecessary vusb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <69be697d-71a1-4773-a6e9-7e506184609f@foss.st.com>
Date: Mon, 10 Nov 2025 09:58:32 +0100
From: Alexandre TORGUE <alexandre.torgue@...s.st.com>
To: Ahmad Fatoum <a.fatoum@...gutronix.de>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>
CC: <devicetree@...r.kernel.org>, <linux-stm32@...md-mailman.stormreply.com>,
        <linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
        <kernel@...gutronix.de>
Subject: Re: [PATCH] ARM: dts: stm32: lxa: drop unnecessary vusb_d/a-supply

Hi Ahmad

On 10/7/25 07:36, Ahmad Fatoum wrote:
> The LXA device trees are the only STM32MP1 device tree that specify
> vusb_d/usb_a-supply and apparently not for good reason:
> 
> - vusb_d-supply (vdd_usb) is the same as the phy-supply for usbphyc_port1
> - vusb_a-supply (reg18) is the same as vdda1v8-supply for usbphyc_port1
> 
> and usbphyc_port1 is linked to the usbotg_hs node via the phys property.
> 
> Specifying the regulators in the &usbotg_hs node is thus superfluous and
> has been even found to be harmful in one instance:
> Linux v6.10 was found to lock up every 50-125 or so reboots on the LXA
> TAC when the DWC2 driver probe enables the regulators in bulk, unless
> both properties were removed.
> 
> This issue was so far not reproducible on v6.17 (> 500 reboots), but as
> these properties are unnecessary and different from other STM32MP1
> boards, remove them anyway.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@...gutronix.de>
> ---
>   arch/arm/boot/dts/st/stm32mp153c-lxa-fairytux2.dtsi | 3 ---
>   arch/arm/boot/dts/st/stm32mp15xc-lxa-tac.dtsi       | 3 ---
>   2 files changed, 6 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/st/stm32mp153c-lxa-fairytux2.dtsi b/arch/arm/boot/dts/st/stm32mp153c-lxa-fairytux2.dtsi
> index 9eeb9d6b5eb0ed35d4a83b743e8007f19422e2ed..7d3a6a3b5d09ea06689ebca11eda48785207aa31 100644
> --- a/arch/arm/boot/dts/st/stm32mp153c-lxa-fairytux2.dtsi
> +++ b/arch/arm/boot/dts/st/stm32mp153c-lxa-fairytux2.dtsi
> @@ -374,9 +374,6 @@ &usbotg_hs {
>   	phys = <&usbphyc_port1 0>;
>   	phy-names = "usb2-phy";
>   
> -	vusb_d-supply = <&vdd_usb>;
> -	vusb_a-supply = <&reg18>;
> -
>   	status = "okay";
>   };
>   
> diff --git a/arch/arm/boot/dts/st/stm32mp15xc-lxa-tac.dtsi b/arch/arm/boot/dts/st/stm32mp15xc-lxa-tac.dtsi
> index be0c355d3105b89d4374d4f6972c7927970f06b1..9179075f2ead14a4deb45fcd2cefd60ab426a8d8 100644
> --- a/arch/arm/boot/dts/st/stm32mp15xc-lxa-tac.dtsi
> +++ b/arch/arm/boot/dts/st/stm32mp15xc-lxa-tac.dtsi
> @@ -493,9 +493,6 @@ &usbotg_hs {
>   	phys = <&usbphyc_port1 0>;
>   	phy-names = "usb2-phy";
>   
> -	vusb_d-supply = <&vdd_usb>;
> -	vusb_a-supply = <&reg18>;
> -
>   	g-rx-fifo-size = <512>;
>   	g-np-tx-fifo-size = <32>;
>   	g-tx-fifo-size = <128 128 64 16 16 16 16 16>;
> 
> ---
> base-commit: 33f3d92bd1bee0e37d68124dd6e7df793a6af745
> change-id: 20251007-lxa-usb-dt-ceb0189396e6
> 
> Best regards,

Applied on stm32-next.

Cheers.
Alex