linux-kernel - Re: [f2fs-dev] [PATCH] f2fs: revert summary entry count from 2048 to 512 in 16kb block support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <17b8c497-c1ad-4a31-a8ad-a5d73b7c2e82@kernel.org>
Date: Mon, 10 Nov 2025 17:22:42 +0800
From: Chao Yu <chao@...nel.org>
To: Daeho Jeong <daeho43@...il.com>, linux-kernel@...r.kernel.org,
 linux-f2fs-devel@...ts.sourceforge.net, kernel-team@...roid.com
Cc: chao@...nel.org, Daeho Jeong <daehojeong@...gle.com>
Subject: Re: [f2fs-dev] [PATCH] f2fs: revert summary entry count from 2048 to
 512 in 16kb block support

On 11/5/25 00:24, Daeho Jeong wrote:
>  static void write_sum_page(struct f2fs_sb_info *sbi,
> -			struct f2fs_summary_block *sum_blk, block_t blk_addr)
> +		struct f2fs_summary_block *sum_blk, unsigned int segno)
>  {
> -	f2fs_update_meta_page(sbi, (void *)sum_blk, blk_addr);
> +	struct folio *folio;

w/ 4k-sized block config, I suffered performance regression issue while testing
fallocate() on pinfile.

Seems we need to add below code:

	if (SUMS_PER_BLOCK == 1)
		return f2fs_update_meta_page(sbi, (void *)sum_blk,
					GET_SUM_BLOCK(sbi, segno));

Otherwise, we will load summary block whenever we change segment for curseg.

Thanks,