linux-kernel - Re: [PATCH 2/2] thermal/drivers/mediatek/lvts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <802768a286aa167f7fdc80857508180964ac7f8c.camel@pengutronix.de>
Date: Mon, 10 Nov 2025 10:53:50 +0100
From: Philipp Zabel <p.zabel@...gutronix.de>
To: Hanchien Lin <hanchien.lin@...iatek.com>, "Rafael J . Wysocki"	
 <rafael@...nel.org>, Daniel Lezcano <daniel.lezcano@...aro.org>, Zhang Rui	
 <rui.zhang@...el.com>, Lukasz Luba <lukasz.luba@....com>, Rob Herring	
 <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley	
 <conor+dt@...nel.org>, Matthias Brugger <matthias.bgg@...il.com>, 
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 Balsam CHIHI <bchihi@...libre.com>
Cc: linux-pm@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-mediatek@...ts.infradead.org, 
	Project_Global_Chrome_Upstream_Group@...iatek.com,
 raymond.sun@...iatek.com, 	Irving-CH.lin@...iatek.com
Subject: Re: [PATCH 2/2] thermal/drivers/mediatek/lvts_thermal: Add MT8189
 support

On Mo, 2025-11-10 at 17:40 +0800, Hanchien Lin wrote:
> Add support for the MediaTek MT8189 SoC to the LVTS thermal driver.
> 
> Signed-off-by: Hanchien Lin <hanchien.lin@...iatek.com>
> ---
>  drivers/thermal/mediatek/lvts_thermal.c | 155 ++++++++++++++++++++++--
>  1 file changed, 144 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/thermal/mediatek/lvts_thermal.c b/drivers/thermal/mediatek/lvts_thermal.c
> index ab55b20cda47..8c15fdaac48c 100644
> --- a/drivers/thermal/mediatek/lvts_thermal.c
> +++ b/drivers/thermal/mediatek/lvts_thermal.c
[...]
> @@ -1334,9 +1359,15 @@ static int lvts_probe(struct platform_device *pdev)
>  	if (IS_ERR(lvts_td->base))
>  		return dev_err_probe(dev, PTR_ERR(lvts_td->base), "Failed to map io resource\n");
>  
> -	lvts_td->reset = devm_reset_control_get_by_index(dev, 0);
> -	if (IS_ERR(lvts_td->reset))
> -		return dev_err_probe(dev, PTR_ERR(lvts_td->reset), "Failed to get reset control\n");
> +	if (!lvts_data->reset_no_need) {
> +		lvts_td->reset = devm_reset_control_get_by_index(dev, 0);

This should be devm_reset_control_get_exclusive(dev, NULL) instead of
devm_reset_control_get_by_index(dev, 0).

No need to use by_index for a single reset control.

regards
Philipp