linux-kernel - RE: [PATCH v2 1/2] dt-bindings: clock: Add identifiers for VIIF on Toshiba Visconti TMPV770x SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: 
 <TY3PR01MB998221A506B2FDAE11E653DD92CEA@TY3PR01MB9982.jpnprd01.prod.outlook.com>
Date: Mon, 10 Nov 2025 07:59:15 +0000
From: <yuji2.ishikawa@...hiba.co.jp>
To: <krzk@...nel.org>, <mturquette@...libre.com>, <sboyd@...nel.org>,
        <nobuhiro.iwamatsu.x90@...l.toshiba>, <robh@...nel.org>,
        <krzk+dt@...nel.org>, <conor+dt@...nel.org>, <p.zabel@...gutronix.de>
CC: <linux-clk@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>
Subject: RE: [PATCH v2 1/2] dt-bindings: clock: Add identifiers for VIIF on
 Toshiba Visconti TMPV770x SoC

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@...nel.org>
> Sent: Wednesday, October 29, 2025 3:39 PM
> To: ishikawa yuji(石川 悠司 □ＡＩＤＣ○ＥＡ開)
> <yuji2.ishikawa@...hiba.co.jp>; Michael Turquette
> <mturquette@...libre.com>; Stephen Boyd <sboyd@...nel.org>; iwamatsu
> nobuhiro(岩松 信洋 □ＤＩＴＣ○ＣＰＴ)
> <nobuhiro.iwamatsu.x90@...l.toshiba>; Rob Herring <robh@...nel.org>;
> Krzysztof Kozlowski <krzk+dt@...nel.org>; Conor Dooley
> <conor+dt@...nel.org>; Philipp Zabel <p.zabel@...gutronix.de>
> Cc: linux-clk@...r.kernel.org; linux-arm-kernel@...ts.infradead.org;
> linux-kernel@...r.kernel.org; devicetree@...r.kernel.org
> Subject: Re: [PATCH v2 1/2] dt-bindings: clock: Add identifiers for VIIF on
> Toshiba Visconti TMPV770x SoC
> 
> On 29/10/2025 07:13, Yuji Ishikawa wrote:
> > Add clock and reset identifiers for the Video Input Interface.
> > These identifiers support two instances: VIIF0 and VIIF1.
> >
> > Signed-off-by: Yuji Ishikawa <yuji2.ishikawa@...hiba.co.jp>
> > ---
> > Changelog v2:
> > - Do not modify existing identifiers to avoid breaking ABI.
> >   Keep existing identfiers for VIIF0.
> >   Introduce new idenfifiers for VIIF1, following the same naming
> conventions.
> > ---
> >  include/dt-bindings/clock/toshiba,tmpv770x.h | 15 +++++++++++++--
> > include/dt-bindings/reset/toshiba,tmpv770x.h | 10 +++++++++-
> >  2 files changed, 22 insertions(+), 3 deletions(-)
> >
> > diff --git a/include/dt-bindings/clock/toshiba,tmpv770x.h
> > b/include/dt-bindings/clock/toshiba,tmpv770x.h
> > index 5fce71300..ff4ef1be5 100644
> > --- a/include/dt-bindings/clock/toshiba,tmpv770x.h
> > +++ b/include/dt-bindings/clock/toshiba,tmpv770x.h
> > @@ -141,7 +141,10 @@
> >  #define TMPV770X_CLK_PIREFCLK		124
> >  #define TMPV770X_CLK_SBUS		125
> >  #define TMPV770X_CLK_BUSLCK		126
> > -#define TMPV770X_NR_CLK			127
> 
> You cannot change it, as explained last time. If this is not an ABI, then in
> separate patch drop it (see examples in the history for Samsung, NXP and
> probably many more SoCs).

I understand TMPV770X_NR_CLK and others can not be changed.
I'll make a separate patchset to drop them.

> Best regards,
> Krzysztof

Regards,
Yuji Ishikawa