linux-kernel - [PATCH v4] PCI: of: Drop error message on missing of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20251110112110.10620-1-andrea.porta@suse.com>
Date: Mon, 10 Nov 2025 12:21:10 +0100
From: Andrea della Porta <andrea.porta@...e.com>
To: Bjorn Helgaas <bhelgaas@...gle.com>,
	linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	mbrugger@...e.com,
	guillaume.gardet@....com,
	tiwai@...e.com,
	Lizhi Hou <lizhi.hou@....com>,
	Rob Herring <robh@...nel.org>
Cc: Andrea della Porta <andrea.porta@...e.com>
Subject: [PATCH v4] PCI: of: Drop error message on missing of_root node

When CONFIG_PCI_DYNAMIC_OF_NODES is enabled, an error message
is generated if no 'of_root' node is defined.

On DT-based systems, this cannot happen as a root DT node is
always present.
On ACPI-based systems that declare an empty root DT node (e.g.
x86 with CONFIG_OF_EARLY_FLATTREE=y), this also won't happen.
On platforms where ACPI is mutually exclusive to DT (e.g. ARM)
the error will be caught (and possibly shown) by drivers that
rely on the root node.

Drop the error message altogether.

Signed-off-by: Andrea della Porta <andrea.porta@...e.com>
---
CHANGES in V4:
- dropped {} from the single line conditional body

V3: https://lore.kernel.org/all/20251110105415.9584-1-andrea.porta@suse.com/
---
 drivers/pci/of.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/pci/of.c b/drivers/pci/of.c
index 3579265f1198..c222944eec40 100644
--- a/drivers/pci/of.c
+++ b/drivers/pci/of.c
@@ -774,10 +774,8 @@ void of_pci_make_host_bridge_node(struct pci_host_bridge *bridge)
 	}
 
 	/* Check if there is a DT root node to attach the created node */
-	if (!of_root) {
-		pr_err("of_root node is NULL, cannot create PCI host bridge node\n");
+	if (!of_root)
 		return;
-	}
 
 	name = kasprintf(GFP_KERNEL, "pci@%x,%x", pci_domain_nr(bridge->bus),
 			 bridge->bus->number);
-- 
2.35.3