linux-kernel - Re: [PATCH 09/13] platform: surface: Simplify with of_machine_get_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4986f752-ba21-6a5f-641a-e0dadb4abd11@linux.intel.com>
Date: Mon, 10 Nov 2025 13:49:42 +0200 (EET)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
cc: Rob Herring <robh@...nel.org>, Saravana Kannan <saravanak@...gle.com>, 
    "Rafael J. Wysocki" <rafael@...nel.org>, 
    Viresh Kumar <viresh.kumar@...aro.org>, 
    Matthias Brugger <matthias.bgg@...il.com>, 
    AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, 
    Yangtao Li <tiny.windzz@...il.com>, Chen-Yu Tsai <wens@...nel.org>, 
    Jernej Skrabec <jernej.skrabec@...il.com>, 
    Samuel Holland <samuel@...lland.org>, 
    Lorenzo Pieralisi <lpieralisi@...nel.org>, 
    Daniel Lezcano <daniel.lezcano@...aro.org>, 
    Bjorn Andersson <andersson@...nel.org>, 
    Konrad Dybcio <konradybcio@...nel.org>, 
    Thomas Gleixner <tglx@...utronix.de>, 
    Nicolas Ferre <nicolas.ferre@...rochip.com>, 
    Alexandre Belloni <alexandre.belloni@...tlin.com>, 
    Claudiu Beznea <claudiu.beznea@...on.dev>, 
    Maximilian Luz <luzmaximilian@...il.com>, Hans de Goede <hansg@...nel.org>, 
    Daniel Lezcano <daniel.lezcano@...nel.org>, 
    Thierry Reding <thierry.reding@...il.com>, 
    Jonathan Hunter <jonathanh@...dia.com>, devicetree@...r.kernel.org, 
    LKML <linux-kernel@...r.kernel.org>, linux-pm@...r.kernel.org, 
    linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org, 
    linux-sunxi@...ts.linux.dev, linux-arm-msm@...r.kernel.org, 
    platform-driver-x86@...r.kernel.org, linux-tegra@...r.kernel.org
Subject: Re: [PATCH 09/13] platform: surface: Simplify with
 of_machine_get_match_data()

On Thu, 6 Nov 2025, Krzysztof Kozlowski wrote:

Please change the prefixes to:

platform/surface: aggregator_registry: ...

Once that is changed,

Acked-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>

-- 
 i.

> Replace open-coded getting root OF node, matching against it and getting
> the match data with new of_machine_get_match_data() helper.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> 
> ---
> 
> Depends on the first OF patch.
> ---
>  drivers/platform/surface/surface_aggregator_registry.c | 13 +------------
>  1 file changed, 1 insertion(+), 12 deletions(-)
> 
> diff --git a/drivers/platform/surface/surface_aggregator_registry.c b/drivers/platform/surface/surface_aggregator_registry.c
> index a594d5fcfcfd..78ac3a8fbb73 100644
> --- a/drivers/platform/surface/surface_aggregator_registry.c
> +++ b/drivers/platform/surface/surface_aggregator_registry.c
> @@ -491,24 +491,13 @@ static const struct of_device_id ssam_platform_hub_of_match[] __maybe_unused = {
>  static int ssam_platform_hub_probe(struct platform_device *pdev)
>  {
>  	const struct software_node **nodes;
> -	const struct of_device_id *match;
> -	struct device_node *fdt_root;
>  	struct ssam_controller *ctrl;
>  	struct fwnode_handle *root;
>  	int status;
>  
>  	nodes = (const struct software_node **)acpi_device_get_match_data(&pdev->dev);
>  	if (!nodes) {
> -		fdt_root = of_find_node_by_path("/");
> -		if (!fdt_root)
> -			return -ENODEV;
> -
> -		match = of_match_node(ssam_platform_hub_of_match, fdt_root);
> -		of_node_put(fdt_root);
> -		if (!match)
> -			return -ENODEV;
> -
> -		nodes = (const struct software_node **)match->data;
> +		nodes = (const struct software_node **)of_machine_get_match_data(ssam_platform_hub_of_match);
>  		if (!nodes)
>  			return -ENODEV;
>  	}
> 
>