linux-kernel - Re: [PATCH 2/3] dt-bindings: regulator: Add Fitipower FP9931/JD9930

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251110132807.1ceb82b5@kemnade.info>
Date: Mon, 10 Nov 2025 13:28:07 +0100
From: Andreas Kemnade <andreas@...nade.info>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Liam Girdwood <lgirdwood@...il.com>,
 Mark Brown <broonie@...nel.org>, Guenter Roeck <linux@...ck-us.net>,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-hwmon@...r.kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: regulator: Add Fitipower FP9931/JD9930

On Mon, 10 Nov 2025 08:30:41 +0100
Krzysztof Kozlowski <krzk@...nel.org> wrote:

> On 09/11/2025 22:12, Andreas Kemnade wrote:
> >>
> >> You must drop ref. That's the entire point of common unit suffix.
> >>  
> > I tried without it:
> > 
> >   fitipower,tdly-ms:
> >     description:
> >       Power up soft start delay settings tDLY1-4 bitfields in the
> >       POWERON_DELAY register
> >     default: <0 0 0 0>  
> 
> Arrays are in [] (see also some examples of arrays in the example-schema).
> [0, 0, 0, 0]
> 
> And then it should work, but does not which I think is bug in dtschema.
> I think it works fine when you drop the "default:" completely, so please
> do so. I'll take a look at the issue.
>
ok, dropping default makes dtschema happy.

> enum should be in one line, btw.
> 
> Your patchset has also blank line warnings.
I fixed the ones shown by

checkpatch.pl --strict

are there any more I am missing?

Regards,
Andreas