linux-kernel - Re: [PATCH v5 1/2] audit: add audit_log_packet_ip4 and audit_log_packet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aRHd_WFBcyiL1Ufe@strlen.de>
Date: Mon, 10 Nov 2025 13:43:48 +0100
From: Florian Westphal <fw@...len.de>
To: Ricardo Robaina <rrobaina@...hat.com>
Cc: Paul Moore <paul@...l-moore.com>, audit@...r.kernel.org,
	linux-kernel@...r.kernel.org, netfilter-devel@...r.kernel.org,
	coreteam@...filter.org, eparis@...hat.com, pablo@...filter.org,
	kadlec@...filter.org
Subject: Re: [PATCH v5 1/2] audit: add audit_log_packet_ip4 and
 audit_log_packet_ip6 helper functions

Ricardo Robaina <rrobaina@...hat.com> wrote:
> > +int audit_log_nft_skb(struct audit_buffer *ab,
> > +                     struct sk_buff *skb, u8 nfproto)
> Thanks for reviewing this patch, Paul.
> 
> It makes sense to me. I'll work on a newer version addressing your suggestions.

Nit, but as you need to resend anyway, can you also make this
'const struct sk_buff *' ?

Also, given this isn't nftables specific, I suggest
audit_log_nf_skb, audit_log_netfilter_skb or some such instead.

Thanks.