linux-kernel - Re: [PATCH v6 00/22] wifi: nxpwifi: create nxpwifi to support iw61x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4eaa11d66e9b788d9824c5b8ab1f1618791b53f3.camel@sipsolutions.net>
Date: Tue, 11 Nov 2025 11:37:57 +0100
From: Johannes Berg <johannes@...solutions.net>
To: Jeff Chen <jeff.chen_1@....com>, linux-wireless@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, briannorris@...omium.org, 
	francesco@...cini.it, tsung-hsien.hsieh@....com, s.hauer@...gutronix.de
Subject: Re: [PATCH v6 00/22] wifi: nxpwifi: create nxpwifi to support iw61x

Hi,

So ... I thought I was just going to pick this up now (removing the
'inline' in patch 4 that shouldn't be there according to the bot), but
... it doesn't build (cleanly) for me.

First:

  CC [M]  drivers/net/wireless/nxp/nxpwifi/util.o
drivers/net/wireless/nxp/nxpwifi/util.c: In function ‘nxpwifi_rxpdinfo_to_radiotapinfo’:
drivers/net/wireless/nxp/nxpwifi/util.c:648:12: error: variable ‘ext_rate_info’ set but not used [-Werror=unused-but-set-variable]
  648 |         u8 ext_rate_info = 0;
      |            ^~~~~~~~~~~~~
cc1: all warnings being treated as errors


Fixing that, I not only get a LOT of sparse warnings such as

  CHECK   drivers/net/wireless/nxp/nxpwifi/util.c
drivers/net/wireless/nxp/nxpwifi/util.c:654:40: warning: restricted __le32 degrades to integer
drivers/net/wireless/nxp/nxpwifi/util.c:655:38: warning: restricted __le32 degrades to integer

but also a bunch of sparse _errors_ such as:

  CHECK   drivers/net/wireless/nxp/nxpwifi/cfg80211.c
drivers/net/wireless/nxp/nxpwifi/cfg80211.c:1043:17: error: typename in expression
drivers/net/wireless/nxp/nxpwifi/cfg80211.c:1043:24: error: Expected ; at end of statement
drivers/net/wireless/nxp/nxpwifi/cfg80211.c:1043:24: error: got const
drivers/net/wireless/nxp/nxpwifi/cfg80211.c:1043:17: error: undefined identifier 'static'
drivers/net/wireless/nxp/nxpwifi/cfg80211.c:1058:32: error: undefined identifier 'legacy_rates'
drivers/net/wireless/nxp/nxpwifi/cfg80211.c:1058:32: error: undefined identifier 'legacy_rates'
drivers/net/wireless/nxp/nxpwifi/cfg80211.c:1059:40: error: undefined identifier 'legacy_rates'


Can you please take a look at that?

johannes