linux-kernel - Re: [PATCH v1 2/2] arm64: dts: qcom: Add support to validate direct DSI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <uhhe4cyv5c4nlwphbgwl22hhl225gfikqdvzxmltnr2kk4nhmi@7mexlu4oesi3>
Date: Tue, 11 Nov 2025 13:10:36 +0200
From: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Sudarshan Shetty <tessolveupstream@...il.com>, andersson@...nel.org,
        konradybcio@...nel.org, robh@...nel.org, krzk+dt@...nel.org,
        conor+dt@...nel.org, linux-arm-msm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 2/2] arm64: dts: qcom: Add support to validate direct
 DSI

On Tue, Nov 11, 2025 at 11:49:41AM +0100, Krzysztof Kozlowski wrote:
> On 11/11/2025 11:42, Sudarshan Shetty wrote:
> > Adds device tree support for the Waveshare 10.1-inch
> > MIPI-DSI panel on the QCS615 talos evk platform.
> 
> Why is this a board? Panel is a hat or sort of addon, so overlay, not a
> board.

Don't waste your time. The developer completely ignored review on the
internal mailing list. I don't see a reason to believe that your review
won't get ignored.

> 
> > 
> > Signed-off-by: Sudarshan Shetty <tessolveupstream@...il.com>
> > ---
> >  arch/arm64/boot/dts/qcom/Makefile          |  1 +
> >  arch/arm64/boot/dts/qcom/talos-evk-dsi.dts | 43 ++++++++++++++++++++++
> >  2 files changed, 44 insertions(+)
> >  create mode 100644 arch/arm64/boot/dts/qcom/talos-evk-dsi.dts
> > 
> > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> > index 282d744acd73..d5a3dd98137d 100644
> > --- a/arch/arm64/boot/dts/qcom/Makefile
> > +++ b/arch/arm64/boot/dts/qcom/Makefile
> > @@ -306,6 +306,7 @@ dtb-$(CONFIG_ARCH_QCOM)	+= sm8650-qrd.dtb
> >  dtb-$(CONFIG_ARCH_QCOM)	+= sm8750-mtp.dtb
> >  dtb-$(CONFIG_ARCH_QCOM)	+= sm8750-qrd.dtb
> >  dtb-$(CONFIG_ARCH_QCOM)	+= talos-evk.dtb
> > +dtb-$(CONFIG_ARCH_QCOM)	+= talos-evk-dsi.dtb
> >  x1e001de-devkit-el2-dtbs	:= x1e001de-devkit.dtb x1-el2.dtbo
> >  dtb-$(CONFIG_ARCH_QCOM)	+= x1e001de-devkit.dtb x1e001de-devkit-el2.dtb
> >  x1e78100-lenovo-thinkpad-t14s-el2-dtbs	:= x1e78100-lenovo-thinkpad-t14s.dtb x1-el2.dtbo
> > diff --git a/arch/arm64/boot/dts/qcom/talos-evk-dsi.dts b/arch/arm64/boot/dts/qcom/talos-evk-dsi.dts
> > new file mode 100644
> > index 000000000000..8a6dc8b6bf8f
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/qcom/talos-evk-dsi.dts
> > @@ -0,0 +1,43 @@
> > +// SPDX-License-Identifier: BSD-3-Clause
> > +/*
> > + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
> > + */
> > +/dts-v1/;
> > +
> > +#include "talos-evk-cb.dtsi"
> > +
> > +&i2c1 {
> > +	clock-frequency = <400000>;
> > +
> > +	status = "okay";
> > +
> > +	display_mcu: display-mcu@45 {
> > +		compatible = "waveshare,touchscreen-panel-regulator";
> 
> 
> It does not look like you tested the DTS against bindings. Please run
> `make dtbs_check W=1` (see
> Documentation/devicetree/bindings/writing-schema.rst or
> https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
> for instructions).
> Maybe you need to update your dtschema and yamllint. Don't rely on
> distro packages for dtschema and be sure you are using the latest
> released dtschema.
> 
> 
> Best regards,
> Krzysztof

-- 
With best wishes
Dmitry