linux-kernel - Re: [PATCH v4 2/2] arm64: dts: add support for NXP i.MX8MP FRDM board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOMZO5CU09fcBB8oUOO=qC=Du3Q9gnJOQacK=6v+pnSQViex3g@mail.gmail.com>
Date: Tue, 11 Nov 2025 08:50:39 -0300
From: Fabio Estevam <festevam@...il.com>
To: Daniel Baluta <daniel.baluta@...il.com>
Cc: Krzysztof Kozlowski <krzk@...nel.org>, Rogerio Pimentel <rpimentel.silva@...il.com>, robh@...nel.org, 
	krzk+dt@...nel.org, conor+dt@...nel.org, shawnguo@...nel.org, 
	s.hauer@...gutronix.de, kernel@...gutronix.de, 
	alexander.stein@...tq-group.com, dario.binacchi@...rulasolutions.com, 
	marex@...x.de, Markus.Niebel@...group.com, y.moog@...tec.de, 
	joao.goncalves@...adex.com, frieder.schrempf@...tron.de, josua@...id-run.com, 
	francesco.dolcini@...adex.com, primoz.fiser@...ik.com, imx@...ts.linux.dev, 
	linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Xiaofeng Wei <xiaofeng.wei@....com>
Subject: Re: [PATCH v4 2/2] arm64: dts: add support for NXP i.MX8MP FRDM board

Hi Daniel,

On Tue, Nov 11, 2025 at 5:45 AM Daniel Baluta <daniel.baluta@...il.com> wrote:

> In addition to that, Rogerio please read:
>
> https://docs.kernel.org/process/submitting-patches.html
>
> At this moment I think you should keep the original author of the
> patch.

Right, but NXP makes a total mess with authorship.

Please see this version from February that states the original author
as Xiaofeng Wei <xiaofeng.wei@....com>:

https://github.com/nxp-imx-support/meta-imx-frdm/blob/lf-6.6.36-2.1.0/meta-imx-bsp/recipes-kernel/linux/linux-imx/0023-arm64-dts-Add-i.MX8MP-FRDM-board-support.patch

Then this one from July states the original author as Joseph Guo
<qijian.guo@....com> and it also has:

Signed-off-by: Steven Yang <steven.yang@....com>
Signed-off-by: Lei Xu <lei.xu@....com>

https://github.com/nxp-imx/linux-imx/commit/fd8010b46bb00344fa519c73b643fad71da5887b

How are we supposed to know the correct authorship tags from the NXP
commit, then?

> Then mark your contribution as follows. If you just picked the patches
> tested them and made minor modifictions only add your S-o-b
>
> e.g
>
> Signed-off-by: Xiaofeng Wei <xiaofeng.wei@....com>
> Signed-off-by: Rogerio Pimentel <rpimentel.silva@...il.com>
>
> If you made significant changes add your C-d-b like this:
>
> Signed-off-by: Xiaofeng Wei <xiaofeng.wei@....com>
> Co-developed-by: Rogerio Pimentel <rpimentel.silva@...il.com>
> Signed-off-by: Rogerio Pimentel <rpimentel.silva@...il.com>

Rogerio's changes are significant as the dt-schema passes now.

The NXP commit has all the dt-schema warnings found in downstream BSPs.

For example, it makes the old mistake of describing:

 spidev1: spi@0 {
   reg = <0>;
    compatible = "lwn,bk4";
    spi-max-frequency = <1000000>;
 };

Which is totally wrong.