linux-kernel - Re: [PATCH v5 5/6] nvme-tcp: Support KeyUpdate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f7dd4e03-352f-48ba-8a0d-ab9e793ef385@oracle.com>
Date: Wed, 12 Nov 2025 09:31:35 -0500
From: Chuck Lever <chuck.lever@...cle.com>
To: Christoph Hellwig <hch@....de>, alistair23@...il.com
Cc: hare@...nel.org, kernel-tls-handshake@...ts.linux.dev,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-doc@...r.kernel.org, linux-nvme@...ts.infradead.org,
        linux-nfs@...r.kernel.org, kbusch@...nel.org, axboe@...nel.dk,
        sagi@...mberg.me, kch@...dia.com, hare@...e.de,
        Alistair Francis <alistair.francis@....com>
Subject: Re: [PATCH v5 5/6] nvme-tcp: Support KeyUpdate

On 11/12/25 1:59 AM, Christoph Hellwig wrote:
> On Wed, Nov 12, 2025 at 02:27:19PM +1000, alistair23@...il.com wrote:
>>  
>>  		ret = sock_recvmsg(queue->sock, &msg, msg.msg_flags);
>>  		if (ret < 0) {
>> +			/* If MSG_CTRUNC is set, it's a control message,
>> +			 * so let's read the control message.
>> +			 */
> This is not the normal kernel comment style, which would be:
> 
> 			/*
> 			 * If MSG_CTRUNC is set, it's a control message, so
> 			 * let's read the control message.
> +			 */

But it is correct style for net/ .


-- 
Chuck Lever