linux-kernel - Re: [PATCH v17 0/9] platform/x86: Add asus-armoury driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aRSdHcO1WCPmG63W@black.igk.intel.com>
Date: Wed, 12 Nov 2025 15:43:41 +0100
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Denis Benato <denis.benato@...ux.dev>
Cc: linux-kernel@...r.kernel.org, platform-driver-x86@...r.kernel.org,
	Hans de Goede <hansg@...nel.org>,
	Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
	"Limonciello, Mario" <mario.limonciello@....com>,
	"Luke D . Jones" <luke@...nes.dev>,
	Alok Tiwari <alok.a.tiwari@...cle.com>,
	Derek John Clark <derekjohn.clark@...il.com>,
	Mateusz Schyboll <dragonn@...pl>, porfet828@...il.com,
	Denis Benato <benato.denis96@...il.com>
Subject: Re: [PATCH v17 0/9] platform/x86: Add asus-armoury driver

On Sun, Nov 02, 2025 at 10:53:10PM +0100, Denis Benato wrote:
> Hi all,
> 
> the TL;DR:
> 1. Introduce new module to contain bios attributes, using fw_attributes_class
> 2. Deprecate all possible attributes from asus-wmi that were added ad-hoc
> 3. Remove those in the next LTS cycle
> 
> The idea for this originates from a conversation with Mario Limonciello
> https://lore.kernel.org/platform-driver-x86/371d4109-a3bb-4c3b-802f-4ec27a945c99@amd.com/
> 
> It is without a doubt much cleaner to use, easier to discover, and the
> API is well defined as opposed to the random clutter of attributes I had
> been placing in the platform sysfs. Given that Derek is also working on a
> similar approach to Lenovo in part based on my initial work I'd like to think
> that the overall approach is good and may become standardised for these types
> of things.
> 
> Regarding PPT: it is intended to add support for "custom" platform profile
> soon. If it's a blocker for this patch series being accepted I will drop the 
> platform-x86-asus-armoury-add-ppt_-and-nv_-tuning.patch and get that done
> separately to avoid holding the bulk of the series up. Ideally I would like
> to get the safe limits in so users don't fully lose functionality or continue
> to be exposed to potential instability from setting too low, or be mislead
> in to thinking they can set limits higher than actual limit.
> 
> The bulk of the PPT patch is data, the actual functional part is relatively
> small and similar to the last version.
> 
> Unfortunately I've been rather busy over the months and may not cover
> everything in the v7 changelog but I've tried to be as comprehensive as I can.

This is more files starter with asus in PDx86.
Perhaps it's a time to have drivers/platform/x86/asus/ ?

-- 
With Best Regards,
Andy Shevchenko