linux-kernel - Re: [PATCH net-next v4 1/3] net: stmmac: Add generic suspend/resume helper for PCI-based controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251112065720.017c4d07@kernel.org>
Date: Wed, 12 Nov 2025 06:57:20 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Yao Zi <ziyao@...root.org>
Cc: Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
 <pabeni@...hat.com>, Yanteng Si <si.yanteng@...ux.dev>, Huacai Chen
 <chenhuacai@...nel.org>, "Russell King (Oracle)"
 <rmk+kernel@...linux.org.uk>, Philipp Stanner <phasta@...nel.org>, Tiezhu
 Yang <yangtiezhu@...ngson.cn>, Qunqin Zhao <zhaoqunqin@...ngson.cn>,
 Vladimir Oltean <vladimir.oltean@....com>, Furong Xu <0x1207@...il.com>,
 Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>, Jacob Keller
 <jacob.e.keller@...el.com>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v4 1/3] net: stmmac: Add generic suspend/resume
 helper for PCI-based controllers

On Tue, 11 Nov 2025 10:07:26 +0000 Yao Zi wrote:
> +config STMMAC_LIBPCI
> +	tristate "STMMAC PCI helper library"
> +	depends on PCI
> +	default y
> +	help
> +	  This selects the PCI bus helpers for the stmmac driver. If you
> +	  have a controller with PCI interface, say Y or M here.

I didn't pay enough attention to the discussion on v2, sorry.
I understand that there's precedent for a library symbol hiding
real symbols in this driver but it really makes for a poor user
experience.

The symbol should be hidden, and select'ed by what needs it.
With the PCI dependency on the real symbol, not here.

The "default y" may draw the attention of the Superior Penguin.
He may have quite a lot to criticize in this area, so let's
not risk it..