linux-kernel - Re: [PATCH v14 1/7] timers: Rename tmigr 'online' bit to 'available'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aRSrpgytUvrP6Res@localhost.localdomain>
Date: Wed, 12 Nov 2025 16:45:42 +0100
From: Frederic Weisbecker <frederic@...nel.org>
To: Gabriele Monaco <gmonaco@...hat.com>
Cc: linux-kernel@...r.kernel.org,
	Anna-Maria Behnsen <anna-maria@...utronix.de>,
	Thomas Gleixner <tglx@...utronix.de>,
	Waiman Long <llong@...hat.com>
Subject: Re: [PATCH v14 1/7] timers: Rename tmigr 'online' bit to 'available'

Le Tue, Nov 04, 2025 at 11:47:33AM +0100, Gabriele Monaco a écrit :
> The timer migration hierarchy excludes offline CPUs via the
> tmigr_is_not_available function, which is essentially checking the
> online bit for the CPU.
> 
> Rename the online bit to available and all references in function names
> and tracepoint to generalise the concept of available CPUs.
> 
> Reviewed-by: Frederic Weisbecker <frederic@...nel.org>
> Signed-off-by: Gabriele Monaco <gmonaco@...hat.com>
> ---
>  include/trace/events/timer_migration.h |  4 ++--
>  kernel/time/timer_migration.c          | 22 +++++++++++-----------
>  kernel/time/timer_migration.h          |  2 +-
>  3 files changed, 14 insertions(+), 14 deletions(-)
> 
> diff --git a/include/trace/events/timer_migration.h b/include/trace/events/timer_migration.h
> index 47db5eaf2f9ab..61171b13c687c 100644
> --- a/include/trace/events/timer_migration.h
> +++ b/include/trace/events/timer_migration.h
> @@ -173,14 +173,14 @@ DEFINE_EVENT(tmigr_cpugroup, tmigr_cpu_active,
>  	TP_ARGS(tmc)
>  );
>  
> -DEFINE_EVENT(tmigr_cpugroup, tmigr_cpu_online,
> +DEFINE_EVENT(tmigr_cpugroup, tmigr_cpu_available,
>  
>  	TP_PROTO(struct tmigr_cpu *tmc),
>  
>  	TP_ARGS(tmc)
>  );
>  
> -DEFINE_EVENT(tmigr_cpugroup, tmigr_cpu_offline,
> +DEFINE_EVENT(tmigr_cpugroup, tmigr_cpu_unavailable,
>  
>  	TP_PROTO(struct tmigr_cpu *tmc),
>  
> diff --git a/kernel/time/timer_migration.c b/kernel/time/timer_migration.c
> index c0c54dc5314c3..78700f90944f0 100644
> --- a/kernel/time/timer_migration.c
> +++ b/kernel/time/timer_migration.c
> @@ -427,7 +427,7 @@ static DEFINE_PER_CPU(struct tmigr_cpu, tmigr_cpu);
>  
>  static inline bool tmigr_is_not_available(struct tmigr_cpu *tmc)
>  {
> -	return !(tmc->tmgroup && tmc->online);
> +	return !(tmc->tmgroup && tmc->available);

Please rebase and test your patchset on top of:

git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
	timers/core

There is one more "->online" field to rename there.

Thanks.

-- 
Frederic Weisbecker
SUSE Labs