linux-kernel - [PATCH] scsi: esas2r: Add check for alloc_ordered

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20251112031521.2000-1-vulab@iscas.ac.cn>
Date: Wed, 12 Nov 2025 11:15:21 +0800
From: Haotian Zhang <vulab@...as.ac.cn>
To: linuxdrivers@...otech.com,
	James.Bottomley@...senPartnership.com,
	martin.petersen@...cle.com
Cc: linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Haotian Zhang <vulab@...as.ac.cn>
Subject: [PATCH] scsi: esas2r: Add check for alloc_ordered_workqueue() return value

alloc_ordered_workqueue() may return NULL. Failure to check this
could lead to NULL pointer dereference.

Add return value check and call esas2r_kill_adapter() on failure
to ensure proper cleanup.

Fixes: 26780d9e12ed ("[SCSI] esas2r: ATTO Technology ExpressSAS 6G SAS/SATA RAID Adapter Driver")
Signed-off-by: Haotian Zhang <vulab@...as.ac.cn>
---
 drivers/scsi/esas2r/esas2r_init.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/scsi/esas2r/esas2r_init.c b/drivers/scsi/esas2r/esas2r_init.c
index 04a07fe57be2..640b59250f72 100644
--- a/drivers/scsi/esas2r/esas2r_init.c
+++ b/drivers/scsi/esas2r/esas2r_init.c
@@ -313,6 +313,12 @@ int esas2r_init_adapter(struct Scsi_Host *host, struct pci_dev *pcid,
 	esas2r_fw_event_off(a);
 	a->fw_event_q =
 		alloc_ordered_workqueue("esas2r/%d", WQ_MEM_RECLAIM, a->index);
+	if (!a->fw_event_q) {
+		esas2r_log(ESAS2R_LOG_CRIT,
+				"failed to allocate fw_event workqueue!");
+		esas2r_kill_adapter(index);
+		return 0;
+	}
 
 	init_waitqueue_head(&a->buffered_ioctl_waiter);
 	init_waitqueue_head(&a->nvram_waiter);
-- 
2.50.1.windows.1