linux-kernel - Re: [PATCH v2] coresight: etm-perf: Fix reference count leak in etm_setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <197141a4-bbfc-40df-8860-1291b810f676@arm.com>
Date: Wed, 12 Nov 2025 15:15:34 +0000
From: Leo Yan <leo.yan@....com>
To: Ma Ke <make24@...as.ac.cn>, suzuki.poulose@....com,
 mike.leach@...aro.org, james.clark@...aro.org,
 alexander.shishkin@...ux.intel.com, mathieu.poirier@...aro.org
Cc: coresight@...ts.linaro.org, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
 stable@...r.kernel.org
Subject: Re: [PATCH v2] coresight: etm-perf: Fix reference count leak in
 etm_setup_aux

On 11/12/25 01:24, Ma Ke wrote:

> @@ -454,6 +454,11 @@ static void *etm_setup_aux(struct perf_event *event, void **pages,
>  		goto err;
>  
>  out:
> +	if (user_sink) {
> +		put_device(&user_sink->dev);
> +		user_sink = NULL;
> +	}

After searched kernel, I prefer to put device in coresight_get_sink_by_id().
Please refer acpi_dev_present() how to do that.

I would like Suzuki's confirmation in case I introduce noise.

Thanks,
Leo