linux-kernel - Re: [PATCH v1 04/26] mm: vmscan: refactor move_folios_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251112104508.5500ad9b@gandalf.local.home>
Date: Wed, 12 Nov 2025 10:45:08 -0500
From: Steven Rostedt <rostedt@...dmis.org>
To: Shakeel Butt <shakeel.butt@...ux.dev>
Cc: Sebastian Andrzej Siewior <bigeasy@...utronix.de>, Harry Yoo
 <harry.yoo@...cle.com>, Qi Zheng <qi.zheng@...ux.dev>, hannes@...xchg.org,
 hughd@...gle.com, mhocko@...e.com, roman.gushchin@...ux.dev,
 muchun.song@...ux.dev, david@...hat.com, lorenzo.stoakes@...cle.com,
 ziy@...dia.com, imran.f.khan@...cle.com, kamalesh.babulal@...cle.com,
 axelrasmussen@...gle.com, yuanchu@...gle.com, weixugc@...gle.com,
 akpm@...ux-foundation.org, linux-mm@...ck.org,
 linux-kernel@...r.kernel.org, cgroups@...r.kernel.org, Muchun Song
 <songmuchun@...edance.com>, Qi Zheng <zhengqi.arch@...edance.com>, Clark
 Williams <clrkwllms@...nel.org>, linux-rt-devel@...ts.linux.dev
Subject: Re: [PATCH v1 04/26] mm: vmscan: refactor move_folios_to_lru()

On Tue, 11 Nov 2025 08:44:14 -0800
Shakeel Butt <shakeel.butt@...ux.dev> wrote:

> Harry is talking about mod_node_page_state() on
> !CONFIG_HAVE_CMPXCHG_LOCAL which is disabling irqs.
> 
> void mod_node_page_state(struct pglist_data *pgdat, enum node_stat_item item,
> 					long delta)
> {
> 	unsigned long flags;
> 
> 	local_irq_save(flags);
> 	__mod_node_page_state(pgdat, item, delta);
> 	local_irq_restore(flags);
> }
> 
> Is PREEMPT_RT fine with this?

But should be:

void mod_node_page_state(struct pglist_data *pgdat, enum node_stat_item item,
					long delta)
{
	guard(irqsave)();
	__mod_node_page_state(pgdat, item, delta);
}

-- Steve