linux-kernel - Re: [PATCH v5 0/6] Use Rust Bitmap from Rust Binder driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aRSrCRvCTu9Y3pW3@yury>
Date: Wed, 12 Nov 2025 10:43:05 -0500
From: Yury Norov <yury.norov@...il.com>
To: Alice Ryhl <aliceryhl@...gle.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Arve Hjønnevåg <arve@...roid.com>,
	Todd Kjos <tkjos@...roid.com>, Martijn Coenen <maco@...roid.com>,
	Joel Fernandes <joelagnelf@...dia.com>,
	Christian Brauner <brauner@...nel.org>,
	Carlos Llamas <cmllamas@...gle.com>,
	Suren Baghdasaryan <surenb@...gle.com>, Burak Emir <bqe@...gle.com>,
	Miguel Ojeda <ojeda@...nel.org>, Boqun Feng <boqun.feng@...il.com>,
	Gary Guo <gary@...yguo.net>,
	Björn Roy Baron <bjorn3_gh@...tonmail.com>,
	Benno Lossin <lossin@...nel.org>,
	Andreas Hindborg <a.hindborg@...nel.org>,
	Trevor Gross <tmgross@...ch.edu>,
	Danilo Krummrich <dakr@...nel.org>, rust-for-linux@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 0/6] Use Rust Bitmap from Rust Binder driver

On Wed, Nov 12, 2025 at 12:47:18PM +0000, Alice Ryhl wrote:
> See commit message for rust binder commit for details.
> 
> Signed-off-by: Alice Ryhl <aliceryhl@...gle.com>
> ---
> Changes in v5:
> - Rename NO_ALLOC_MAX_LEN to MAX_INLINE_LEN.
> - Update all uses of MAX_LEN/MAX_INLINE_LEN to reference the new
>   constants.
> - Link to v4: https://lore.kernel.org/r/20251110-binder-bitmap-v4-0-5ed8a7fab1b9@google.com

Patches 2 and 4 still refer to NO_ALLOC_MAX_LEN. I think you need to
resend.

Thanks,
Yury
 
> Changes in v4:
> - Keep existing IdPool constructor (renamed to with_capacity).
> - Undo docs changes that were due to the removal of the existing IdPool
>   constructor.
> - List id < pool.map.len() as invariant for UnusedId and mention it in
>   as_u32() comment.
> - Fix [`acquire`] docs links.
> - Link to v3: https://lore.kernel.org/r/20251028-binder-bitmap-v3-0-32822d4b3207@google.com
> 
> Changes in v3:
> - Also update documentation to fix compile errors.
> - Use new_inline() instead of new_small().
> - Reword commit message of "rust: id_pool: do not supply starting capacity"
> - Change UnusedId::acquire() to return usize.
> - Link to v2: https://lore.kernel.org/r/20251021-binder-bitmap-v2-0-e652d172c62b@google.com
> 
> Changes in v2:
> - Use id_pool.
> - Link to v1: https://lore.kernel.org/r/20251020-binder-bitmap-v1-0-879bec9cddc1@google.com
> 
> ---
> Alice Ryhl (6):
>       rust: bitmap: add MAX_LEN and MAX_INLINE_LEN constants
>       rust: bitmap: add BitmapVec::new_inline()
>       rust: bitmap: rename IdPool::new() to with_capacity()
>       rust: id_pool: do not supply starting capacity
>       rust: id_pool: do not immediately acquire new ids
>       rust_binder: use bitmap for allocation of handles
> 
>  drivers/android/binder/process.rs |  63 ++++++++++++++-----
>  rust/kernel/bitmap.rs             |  43 ++++++++-----
>  rust/kernel/id_pool.rs            | 129 ++++++++++++++++++++++++++++----------
>  3 files changed, 171 insertions(+), 64 deletions(-)
> ---
> base-commit: 211ddde0823f1442e4ad052a2f30f050145ccada
> change-id: 20251007-binder-bitmap-5aa0d966fb1f
> 
> Best regards,
> -- 
> Alice Ryhl <aliceryhl@...gle.com>