linux-kernel - Re: [PATCH 01/10] of/fdt: Introduce dt_root_addr_size_cells() and dt_root_addr_size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdUOXjMOxOn5oU1jftAVKk6b+8LN-72H5tAqaAyvysxhLQ@mail.gmail.com>
Date: Wed, 12 Nov 2025 17:25:37 +0100
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Yuntao Wang <yuntao.wang@...ux.dev>
Cc: Rob Herring <robh@...nel.org>, Saravana Kannan <saravanak@...gle.com>, 
	Catalin Marinas <catalin.marinas@....com>, AKASHI Takahiro <takahiro.akashi@...aro.org>, 
	James Morse <james.morse@....com>, Chen Zhou <chenzhou10@...wei.com>, Baoquan He <bhe@...hat.com>, 
	Zhen Lei <thunder.leizhen@...wei.com>, Andrew Morton <akpm@...ux-foundation.org>, 
	Changyuan Lyu <changyuanl@...gle.com>, Alexander Graf <graf@...zon.com>, 
	"Mike Rapoport (Microsoft)" <rppt@...nel.org>, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 01/10] of/fdt: Introduce dt_root_addr_size_cells() and dt_root_addr_size_bytes()

On Wed, 12 Nov 2025 at 15:37, Yuntao Wang <yuntao.wang@...ux.dev> wrote:
> Currently, many places use the result of the expression
> `(dt_root_addr_cells + dt_root_size_cells) * sizeof(__be32)` for various
> checks.
>
> To improve code maintainability and reduce the chance of errors, extract
> this expression into two helper functions.
>
> Signed-off-by: Yuntao Wang <yuntao.wang@...ux.dev>

Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds