linux-kernel - Re: [PATCH V2 00/10] staging: gpib: Destage gpib drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aRS_8V5udtngcMhk@hovoldconsulting.com>
Date: Wed, 12 Nov 2025 18:12:17 +0100
From: Johan Hovold <johan@...nel.org>
To: Dave Penkler <dpenkler@...il.com>
Cc: gregkh@...uxfoundation.org, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2 00/10] staging: gpib: Destage gpib drivers

On Tue, Nov 11, 2025 at 10:45:02AM +0100, Dave Penkler wrote:
> This patch series is for moving the gpib drivers out of the staging area.

Note that I have no idea whether this code is ready to be moved out of
staging, I'm just commenting on how it is done here.
 
> As many changes as possible (patches 1-6) are done in the staging area
> to prepare for the move. Patches 7-10 do the move and complete the destage.
> 
> Patch 1: Remove gpib from Kconfig and Makefile in staging
> Patch 2: Remove the gpib/uapi directory from include search path
> Patch 3: In the code change the uapi include file paths to <linux/xxx.h>
> Patch 4: Remove comment item in TODO file
> Patch 5: Delete the word Linux from gpib Kconfig option title
> Patch 6: Add SPDX syscall note to uapi gpib headers
> Patch 7: Move the common gpib/uapi headers to include/uapi/linux
> Patch 8: Move the gpib tree out of staging
> Patch 9: Add gpib to Kconfig and Makefile in drivers
> Patch 10: Update MAINTAINERS for post destage

I still think most of these should be squashed into a single patch
that moves things out of staging.

> Dave Penkler (10):
>   staging: Remove gpib build from staging
>   staging: gpib: Remove gpib/uapi from search path
>   staging: gpib: Change file path for uapi headers

>   staging: gpib: Update TODO file

This can be done first before moving.

>   staging: gpib: Change gpib Kconfig option title

This too, but it's hardly worth doing in a separate patch so can be
squashed as well.

>   staging: gpib: Fix SPDX license for gpib headers

Can also be done before moving.

>   uapi: linux: Add common gpib interface headers
>   gpib: Move gpib drivers out of staging
>   gpib: Add gpib build menu and rule to drivers
>   MAINTAINERS: Update for gpib destage

And then squash the rest into a single patch that can be build tested.

Johan