linux-kernel - Re: [PATCH 2/3] mmc: renesas_sdhi: Switch to SYSTEM_SLEEP_PM_OPS()/RUNTIME_PM_OPS() and pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aRTRshYq2MznnCYc@shikoro>
Date: Wed, 12 Nov 2025 19:28:02 +0100
From: Wolfram Sang <wsa+renesas@...g-engineering.com>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: Claudiu <claudiu.beznea@...on.dev>, ulf.hansson@...aro.org,
	p.zabel@...gutronix.de, linux-mmc@...r.kernel.org,
	linux-renesas-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
	Claudiu Beznea <claudiu.beznea.uj@...renesas.com>
Subject: Re: [PATCH 2/3] mmc: renesas_sdhi: Switch to
 SYSTEM_SLEEP_PM_OPS()/RUNTIME_PM_OPS() and pm_ptr()

Hi Geert,

> > -#ifdef CONFIG_PM
> >  int tmio_mmc_host_runtime_suspend(struct device *dev);
> >  int tmio_mmc_host_runtime_resume(struct device *dev);
> > -#endif
> 
> This change is indeed needed, because RUNTIME_PM_OPS() now
> references these two functions unconditionally...
> 
> >
> >  static inline u16 sd_ctrl_read16(struct tmio_mmc_host *host, int addr)
> >  {
> > diff --git a/drivers/mmc/host/tmio_mmc_core.c b/drivers/mmc/host/tmio_mmc_core.c
> > index 775e0d9353d5..8be642f737c7 100644
> > --- a/drivers/mmc/host/tmio_mmc_core.c
> > +++ b/drivers/mmc/host/tmio_mmc_core.c
> > @@ -1286,7 +1286,6 @@ void tmio_mmc_host_remove(struct tmio_mmc_host *host)
> >  }
> >  EXPORT_SYMBOL_GPL(tmio_mmc_host_remove);
> >
> > -#ifdef CONFIG_PM
> >  static int tmio_mmc_clk_enable(struct tmio_mmc_host *host)
> >  {
> >         if (!host->clk_enable)
> > @@ -1331,7 +1330,6 @@ int tmio_mmc_host_runtime_resume(struct device *dev)
> >         return 0;
> >  }
> >  EXPORT_SYMBOL_GPL(tmio_mmc_host_runtime_resume);
> > -#endif
> 
> ... however, no actual code referencing them is emitted in the
> CONFIG_PM=n case, as renesas_sdhi_internal_dmac_dev_pm_ops is not used
> due to the use of pm_ptr().  Hence the changes to this file are needed.
> (verified with m68k allmodconfig/allyesconfig builds)

Since you confirmed all this, did you forget a Rev-by? Or do you
actually describe an issue which I am overlooking?

Happy hacking,

   Wolfram

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)