linux-kernel - Re: [PATCH v3 1/2] dt-bindings: input: i2c-hid: Introduce FocalTech FT8112

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251112-resume-engorge-3dafdc09c65d@spud>
Date: Wed, 12 Nov 2025 18:53:18 +0000
From: Conor Dooley <conor@...nel.org>
To: daniel_peng@...atron.corp-partner.google.com
Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>,
	linux-input@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Rob Herring <robh@...nel.org>, devicetree@...r.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: input: i2c-hid: Introduce FocalTech
 FT8112

On Wed, Nov 12, 2025 at 07:59:04PM +0800, daniel_peng@...atron.corp-partner.google.com wrote:
> From: Daniel Peng <Daniel_Peng@...atron.corp-partner.google.com>
> 
> The FocalTech FT8112 touch screen chip same as Ilitek ili2901 controller
> has a reset gpio. The difference is that they have different
> post_gpio_reset_on_delay_ms.
> FocalTech FT8112 also uses 3.3V power supply.
> 
> Signed-off-by: Daniel Peng <Daniel_Peng@...atron.corp-partner.google.com>

> - Modified the subject description.
> - Modified maintainers to myself of this binding file.
> - Fixed the extra '>' on section of "interrupts = <15 IRQ_TYPE_LEVEL_LOW>;" and confirm command 'make dt_binding_check' correctly.
> - Restored MAINTAINERS file.

The patch seems okay me me, other than this which a) should be below the
--- and also does not appear to even be accurate? The last bullet in
doesn't match the patch contents.
Move this out of the commit and then
Acked-by: Conor Dooley <conor.dooley@...rochip.com>
pw-bot: changes-requested

Thanks,
Conor.

> 
> ---
> 
> (no changes since v1)
> 
>  .../bindings/input/focaltech,ft8112.yaml      | 66 +++++++++++++++++++
>  1 file changed, 66 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/input/focaltech,ft8112.yaml
> 
> diff --git a/Documentation/devicetree/bindings/input/focaltech,ft8112.yaml b/Documentation/devicetree/bindings/input/focaltech,ft8112.yaml
> new file mode 100644
> index 000000000000..197f30b14d45
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/focaltech,ft8112.yaml
> @@ -0,0 +1,66 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/input/focaltech,ft8112.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: FocalTech FT8112 touchscreen controller
> +
> +maintainers:
> +  - Daniel Peng <Daniel_Peng@...atron.corp-partner.google.com>
> +
> +description:
> +  Supports the FocalTech FT8112 touchscreen controller.
> +  This touchscreen controller uses the i2c-hid protocol with a reset GPIO.
> +
> +allOf:
> +  - $ref: /schemas/input/touchscreen/touchscreen.yaml#
> +
> +properties:
> +  compatible:
> +    enum:
> +      - focaltech,ft8112
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  panel: true
> +
> +  reset-gpios:
> +    maxItems: 1
> +
> +  vcc33-supply: true
> +
> +  vccio-supply: true
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - vcc33-supply
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +
> +    i2c {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +
> +      touchscreen@38 {
> +        compatible = "focaltech,ft8112";
> +        reg = <0x38>;
> +
> +        interrupt-parent = <&pio>;
> +        interrupts = <15 IRQ_TYPE_LEVEL_LOW>;
> +
> +        reset-gpios = <&pio 126 GPIO_ACTIVE_LOW>;
> +        vcc33-supply = <&pp3300_tchscr_x>;
> +      };
> +    };
> -- 
> 2.34.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)