linux-kernel - Re: [PATCH] hwmon: (gpd-fan) Fix the compilation error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dfb3f5df-4ca7-4965-bfe9-07fb473f0506@roeck-us.net>
Date: Wed, 12 Nov 2025 12:03:45 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: Cryolitia PukNgae <cryolitia@...ontech.com>, luoqing <l1138897701@....com>
Cc: linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org,
 luoqing@...inos.cn
Subject: Re: [PATCH] hwmon: (gpd-fan) Fix the compilation error

On 11/11/25 19:09, Cryolitia PukNgae wrote:
> On 12/11/2025 09.57, luoqing wrote:
>> From: luoqing <luoqing@...inos.cn>
>>
>> drivers/hwmon/gpd-fan.c: in the function 'gpd_ecram_read' :
>> drivers/hwmon/gpd-fan.c:231:9: Error: implicit declaration function 'outb' [-Werror= implrecental-function-declaration]
>> 231 |         outb(0x2E, addr_port);
>> ^~~~
>> drivers/hwmon/gpd-fan.c:244:16: Error: implicit declaration function 'inb' [-Werror= implrecental-function-declaration]
>> 244 |         *val = inb(data_port);
>> ^~~
>> cc1: All warnings were regarded as errors
>>
>> Signed-off-by: luoqing <luoqing@...inos.cn>
>> ---
>>   drivers/hwmon/gpd-fan.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/hwmon/gpd-fan.c b/drivers/hwmon/gpd-fan.c
>> index 321794807e8d..57d4ee683f0d 100644
>> --- a/drivers/hwmon/gpd-fan.c
>> +++ b/drivers/hwmon/gpd-fan.c
>> @@ -19,6 +19,7 @@
>>   #include <linux/kernel.h>
>>   #include <linux/module.h>
>>   #include <linux/platform_device.h>
>> +#include <linux/io.h>
>>   
>>   #define DRIVER_NAME "gpdfan"
>>   #define GPD_PWM_CTR_OFFSET 0x1841
> 
> Has it already been fixed in it[1] ?
> 
> 1. https://lore.kernel.org/all/20251024202042.752160-1-krishnagopi487@gmail.com/#t
> 
Yes, I'll just need to send the pull request.

Guenter