linux-kernel - Re: [PATCH] fortify: Ignore intermediate *.tmp files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251112223606.GA3268585@ax162>
Date: Wed, 12 Nov 2025 15:36:06 -0700
From: Nathan Chancellor <nathan@...nel.org>
To: WangYuli <wangyuli@...c.io>
Cc: kees@...nel.org, nicolas@...sle.eu, linux-hardening@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-kbuild@...r.kernel.org,
	WangYuli <wangyl5933@...naunicom.cn>
Subject: Re: [PATCH] fortify: Ignore intermediate *.tmp files

On Wed, Nov 12, 2025 at 07:47:25PM +0800, WangYuli wrote:
> From: WangYuli <wangyl5933@...naunicom.cn>
> 
> The test_fortify.sh script generates logs of build-time warnings
> for string and memory functions. To ensure the final log file is
> updated atomically, the script first writes its output to a temporary
> file with a .log.tmp extension. Upon successful completion, this
> temporary file is renamed to the final .log file.
> 
> If the build process is interrupted before this rename operation,
> these *.log.tmp intermediate files will be left in the directory,
> creating a risk of them being accidentally added to the git repository.

Shouldn't the cleanup trap in lib/test_fortify/test_fortify.sh be enough
to avoid leaving behind .log.tmp? Or does that only work for clean
exits? Would adding INT to the trap avoid the problem?

> To prevent this from happening, add *.tmp to the .gitignore file to
> explicitly ignore these temporary files.
> 
> Signed-off-by: WangYuli <wangyl5933@...naunicom.cn>
> Signed-off-by: WangYuli <wangyuli@...c.io>

Regardless, this seems fine in the meantime.

Reviewed-by: Nathan Chancellor <nathan@...nel.org>

> ---
>  lib/test_fortify/.gitignore | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/lib/test_fortify/.gitignore b/lib/test_fortify/.gitignore
> index c1ba37d14b50..8056bc75b442 100644
> --- a/lib/test_fortify/.gitignore
> +++ b/lib/test_fortify/.gitignore
> @@ -1,2 +1,3 @@
>  # SPDX-License-Identifier: GPL-2.0-only
>  /*.log
> +/*.tmp
> -- 
> 2.51.0
>