linux-kernel - Re: [PATCH v2 18/18] vfio: selftests: Add vfio_pci_device_init_perf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aRUQAg1kNVzfKkuv@devgpu015.cco6.facebook.com>
Date: Wed, 12 Nov 2025 14:53:54 -0800
From: Alex Mastro <amastro@...com>
To: David Matlack <dmatlack@...gle.com>
CC: Alex Williamson <alex.williamson@...hat.com>,
        Alex Williamson
	<alex@...zbot.org>, Jason Gunthorpe <jgg@...dia.com>,
        Josh Hilke
	<jrhilke@...gle.com>, <kvm@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-kselftest@...r.kernel.org>,
        Raghavendra Rao Ananta
	<rananta@...gle.com>,
        Vipin Sharma <vipinsh@...gle.com>,
        Aaron Lewis
	<aaronlewis@...gle.com>
Subject: Re: [PATCH v2 18/18] vfio: selftests: Add
 vfio_pci_device_init_perf_test

On Wed, Nov 12, 2025 at 07:22:32PM +0000, David Matlack wrote:
> +static s64 to_ns(struct timespec ts)
> +{
> +	return (s64)ts.tv_nsec + 1000000000LL * (s64)ts.tv_sec;
> +}
> +
> +static struct timespec to_timespec(s64 ns)
> +{
> +	struct timespec ts = {
> +		.tv_nsec = ns % 1000000000LL,
> +		.tv_sec = ns / 1000000000LL,

nit - I think you can get NSEC_PER_SEC from #include <linux/time64.h>
 
Otherwise LGTM

Reviewed-by: Alex Mastro <amastro@...com>