linux-kernel - Re: [PATCH] ASoC: rsnd: fix OF node reference leak in rsnd_ssiu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87qzu2x2r3.wl-kuninori.morimoto.gx@renesas.com>
Date: Wed, 12 Nov 2025 23:14:25 +0000
From: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To: Haotian Zhang <vulab@...as.ac.cn>
Cc: lgirdwood@...il.com,
	broonie@...nel.org,
	perex@...ex.cz,
	tiwai@...e.com,
	geert+renesas@...der.be,
	magnus.damm@...il.com,
	linux-sound@...r.kernel.org,
	linux-renesas-soc@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: rsnd: fix OF node reference leak in rsnd_ssiu_probe()


Hi Haotian

> rsnd_ssiu_probe() leaks an OF node reference obtained by
> rsnd_ssiu_of_node(). The node reference is acquired but
> never released across all return paths.
> 
> Fix it by declaring the device node with the __free(device_node)
> cleanup construct to ensure automatic release when the variable goes
> out of scope.
> 
> Fixes: 4e7788fb8018 ("ASoC: rsnd: add SSIU BUSIF support")
> Signed-off-by: Haotian Zhang <vulab@...as.ac.cn>
> ---

Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>

Thank you for your help !!

Best regards
---
Kuninori Morimoto