linux-kernel - Re: [PATCH RFC] dt-bindings: arm: keystone: add boot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DE6HB50YE2YA.101VZ1IK9JUBT@ti.com>
Date: Wed, 12 Nov 2025 11:19:19 +0530
From: Anshul Dalal <anshuld@...com>
To: Krzysztof Kozlowski <krzk@...nel.org>, Anshul Dalal <anshuld@...com>,
	Nishanth Menon <nm@...com>, Tero Kristo <kristo@...nel.org>, "Santosh
 Shilimkar" <ssantosh@...nel.org>, Rob Herring <robh@...nel.org>, "Krzysztof
 Kozlowski" <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
CC: <linux-arm-kernel@...ts.infradead.org>, <devicetree@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, Vignesh Raghavendra <vigneshr@...com>
Subject: Re: [PATCH RFC] dt-bindings: arm: keystone: add boot_* mailboxes

On Tue Nov 11, 2025 at 4:22 PM IST, Krzysztof Kozlowski wrote:
> On 11/11/2025 11:37, Anshul Dalal wrote:
>> The bootloader on K3 devices makes use of mailboxes as per the ROM spec
>> which might be different than one's available to the kernel (firmware
>> spec).
>
> Why is this RFC? You don't expect review?
>

Oh my bad, I forgot to reset the b4 prefix. This patch isn't meant to be
an RFC.

I will incorporate rest of your feedback as well and post a v2.

Thanks for the review!
Anshul

>> 
>> Therefore, this patch adds the missing mailbox entries to the DT binding
>> to represent the mailboxes exposed by the hardware during boot for the
>> purpose of loading the firmware.
>> 
>> Signed-off-by: Anshul Dalal <anshuld@...com>
>> ---
>>  Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml | 10 +++++++++-
>>  1 file changed, 9 insertions(+), 1 deletion(-)
>> 
>> diff --git a/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml b/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
>> index 25a2b42105e541cb3c8ad12a0dfec1af038fa907..b5f48647a0f09bb930f052ea0f84a78525c925eb 100644
>> --- a/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
>> +++ b/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
>> @@ -51,15 +51,23 @@ properties:
>>      minItems: 1
>>  
>>    mbox-names:
>> +    minItems: 2
>> +    maxItems: 6
>>      description: |
>>        Specifies the mailboxes used to communicate with TI-SCI Controller
>> -      made available from TI-SCI controller.
>> +      made available from TI-SCI controller. All boot_* mailboxes are used by
>> +      the first stage bootloader to load firmware for the device.
>
> Description does not go to mbox-names, but to mboxes.
>
>>      items:
>>        - const: rx
>>        - const: tx
>> +      - const: notify
>> +      - const: boot_rx
>> +      - const: boot_tx
>> +      - const: boot_notify
>>  
>>    mboxes:
>>      minItems: 2
>> +    maxItems: 6
>
> You need to list the items instead.
>
>>  
>>    ti,host-id:
>>      $ref: /schemas/types.yaml#/definitions/uint32
>
> You should update the example so it will be complete.
>
> Best regards,
> Krzysztof