linux-kernel - Re: [PATCH v1] regulator: Add Waveshare panel regulator driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9aafbbd2-ef49-4b6e-aefb-99b03d83b7e6@kernel.org>
Date: Wed, 12 Nov 2025 08:44:18 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Sudarshan Shetty <tessolveupstream@...il.com>, lgirdwood@...il.com,
 broonie@...nel.org
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] regulator: Add Waveshare panel regulator driver

On 11/11/2025 11:43, Sudarshan Shetty wrote:
> This patch adds a regulator driver for Waveshare panels.
> The regulator provides controlled power sequencing and is also used
> to enable or disable the display backlight.
> 
> Features:
>  - I2C interface to control panel-specific regulator registers
>  - GPIO-based enable/disable support
>  - Integration with the Linux regulator framework
> 
> This driver is required for proper initialization of Waveshare
> MIPI-DSI panels supported by the companion DRM panel driver.
> 
> Signed-off-by: Sudarshan Shetty <tessolveupstream@...il.com>
> ---
>  arch/arm64/configs/defconfig                  |   1 +

That is not regulator subsystem, don't mix.

>  drivers/regulator/Kconfig                     |  11 +
>  drivers/regulator/Makefile                    |   1 +
>  drivers/regulator/waveshare-panel-regulator.c | 294 ++++++++++++++++++
>  4 files changed, 307 insertions(+)
You did not implement feedback from your internal review. Please go back
to that first, so you will not ask maintainers to review obvious issues
which were already pointed out.


Best regards,
Krzysztof