linux-kernel - Re: [PATCH v3 2/5] mtd: spi-nor: micron-st: move set_octal_dtr to late

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <60625b83-aef6-442b-8b38-558c3751c4a6@linaro.org>
Date: Wed, 12 Nov 2025 11:01:53 +0200
From: Tudor Ambarus <tudor.ambarus@...aro.org>
To: Haibo Chen <haibo.chen@....com>, Pratyush Yadav <pratyush@...nel.org>,
 Michael Walle <mwalle@...nel.org>, Miquel Raynal
 <miquel.raynal@...tlin.com>, Richard Weinberger <richard@....at>,
 Vignesh Raghavendra <vigneshr@...com>
Cc: linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org,
 imx@...ts.linux.dev
Subject: Re: [PATCH v3 2/5] mtd: spi-nor: micron-st: move set_octal_dtr to
 late_init()



On 11/12/25 8:48 AM, Haibo Chen wrote:
> Move params->set_octal_dtr from flash_info->fixups->default_init()
> to spi_nor_manufacturer-> fixups-> late_init(), this can cover
> all Micorn and ST chips without repeat in each chip's flash_info.
> 
> With this, we can also remove flash_info->size if chip has SFDP.

you could remove flash_info->size when chip has SFDP even before
your patch, as params->size is first initialized with
flash_info->size and then overwritten with the flash size read
from SFDP.

So this comment is misleading and has to be dropped. With that:
Reviewed-by: Tudor Ambarus <tudor.ambarus@...aro.org>