linux-kernel - Re: [RFC PATCH v2 08/23] KVM: x86/tdp_mmu: Alloc external

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aRRTaX6FD6I/tw3w@yzhao56-desk.sh.intel.com>
Date: Wed, 12 Nov 2025 17:29:13 +0800
From: Yan Zhao <yan.y.zhao@...el.com>
To: "Huang, Kai" <kai.huang@...el.com>
CC: "pbonzini@...hat.com" <pbonzini@...hat.com>, "seanjc@...gle.com"
	<seanjc@...gle.com>, "quic_eberman@...cinc.com" <quic_eberman@...cinc.com>,
	"kvm@...r.kernel.org" <kvm@...r.kernel.org>, "Li, Xiaoyao"
	<xiaoyao.li@...el.com>, "Du, Fan" <fan.du@...el.com>, "Hansen, Dave"
	<dave.hansen@...el.com>, "david@...hat.com" <david@...hat.com>,
	"thomas.lendacky@....com" <thomas.lendacky@....com>, "vbabka@...e.cz"
	<vbabka@...e.cz>, "tabba@...gle.com" <tabba@...gle.com>, "kas@...nel.org"
	<kas@...nel.org>, "michael.roth@....com" <michael.roth@....com>, "Weiny, Ira"
	<ira.weiny@...el.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "binbin.wu@...ux.intel.com"
	<binbin.wu@...ux.intel.com>, "ackerleytng@...gle.com"
	<ackerleytng@...gle.com>, "Yamahata, Isaku" <isaku.yamahata@...el.com>,
	"Peng, Chao P" <chao.p.peng@...el.com>, "zhiquan1.li@...el.com"
	<zhiquan1.li@...el.com>, "Annapurve, Vishal" <vannapurve@...gle.com>,
	"Edgecombe, Rick P" <rick.p.edgecombe@...el.com>, "Miao, Jun"
	<jun.miao@...el.com>, "x86@...nel.org" <x86@...nel.org>, "pgonda@...gle.com"
	<pgonda@...gle.com>
Subject: Re: [RFC PATCH v2 08/23] KVM: x86/tdp_mmu: Alloc external_spt page
 for mirror page table splitting

On Tue, Nov 11, 2025 at 05:52:54PM +0800, Huang, Kai wrote:
> On Thu, 2025-08-07 at 17:43 +0800, Yan Zhao wrote:
> > From: Isaku Yamahata <isaku.yamahata@...el.com>
> > 
> > Enhance tdp_mmu_alloc_sp_split() to allocate a page for sp->external_spt,
> 	  ^
> 	  tdp_mmu_alloc_sp_for_split()
Right. 

> [...]
> 
> > +static struct kvm_mmu_page *tdp_mmu_alloc_sp_for_split(bool mirror);
> > +
> 
> It doesn't seem you need such declaration in _this_ patch.  If any later
> patch needs it, then perhaps it's better to do in that patch.
Thanks!
I'll drop this declaration. It's no longer needed for v2, because its caller is
now tdp_mmu_split_huge_pages_root(), which is later than
tdp_mmu_alloc_sp_for_split().