linux-kernel - Re: [PATCH] UFS: Make TM command timeout configurable from host side

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d269635b6c566029d757dff59f4b0cf250b33fb5.camel@mediatek.com>
Date: Wed, 12 Nov 2025 09:42:45 +0000
From: Peter Wang (王信友) <peter.wang@...iatek.com>
To: "beanhuo@...ron.com" <beanhuo@...ron.com>, "sh043.lee@...sung.com"
	<sh043.lee@...sung.com>, "avri.altman@....com" <avri.altman@....com>,
	"storage.sec@...sung.com" <storage.sec@...sung.com>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"bvanassche@....org" <bvanassche@....org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "alim.akhtar@...sung.com"
	<alim.akhtar@...sung.com>, "adrian.hunter@...el.com"
	<adrian.hunter@...el.com>, "martin.petersen@...cle.com"
	<martin.petersen@...cle.com>
Subject: Re: [PATCH] UFS: Make TM command timeout configurable from host side

On Wed, 2025-11-12 at 17:49 +0900, Seunghui Lee wrote:
> 
> Hi Peter,
> 
> Currently, the modification is about changing it in the same way as
> nop_out_timeout.
> The tm_cmd_timeout value is not read from the device.
> Also, if the UFS can read the tm_cmd_timeout value and requires a
> longer timeout period than the specified value, dev quirks would also
> be acceptable.
> 
> However, for now, it seems fine to set it on the host.
> When we checked on our side, it wasn't that the tm timeout value was
> insufficient for specific devices, but rather some vendors needed to
> increase it.
> We plan to appropriately increase and use it. Also, since the current
> modification maintains the default value and allows an appropriate
> value to be adjusted according to each vendor, the current method
> also seems acceptable.
> 
> Thank you,
> Seunghui Lee.
> 

Hi Seunghui,

The nop_out_timeout value can be changed by the host, as shown here:
https://lore.kernel.org/all/20210831145317.26306-1-adrian.hunter@intel.com/
(hba->nop_out_timeout = 200;)

However, in this patch, no one sets tm_cmd_timeout, correct?
So, I am saying that this patch doesn’t actually change anything, 
because the timeout is still 100ms for all hosts.

Thanks
Peter