[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <3c2dee38-46a8-4359-b981-d4e3d53061fe@linaro.org>
Date: Wed, 12 Nov 2025 10:57:21 +0100
From: Daniel Lezcano <daniel.lezcano@...aro.org>
To: Johan Hovold <johan@...nel.org>
Cc: Thomas Gleixner <tglx@...utronix.de>,
Maxime Coquelin <mcoquelin.stm32@...il.com>,
Alexandre Torgue <alexandre.torgue@...s.st.com>,
linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] clocksource/drivers/stm: Fix section mismatches
On 11/10/25 15:51, Johan Hovold wrote:
> Hi Daniel,
>
> On Wed, Nov 05, 2025 at 02:32:18PM +0100, Daniel Lezcano wrote:
>
>> You should replace __init by __init_or_module
>
> That's not sufficient as the driver can still be rebound through sysfs
> currently (the driver would probably crash anyway, but that's a separate
> issue).
>
> Also note that no drivers use __init_or_module these days, likely as
> everyone uses modules and it's not worth the added complexity in trying
> to get the section markers right for a build configuration that few
> people care about.
>
> I can send a follow-on patch to suppress the unbind attribute, or
> include it in a v2 if you insist on using __init_or_module.
>
> What do you prefer?
I think it makes sens to use __init_or_module because these drivers have
been always compiled in and we are converting them into modules.
[ ... ]
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
Powered by blists - more mailing lists